From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
swarren@wwwdotorg.org
Subject: Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type
Date: Tue, 5 Jan 2016 17:41:14 +0000 [thread overview]
Message-ID: <20160105174114.GI6588@sirena.org.uk> (raw)
In-Reply-To: <1450788927-22116-1-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote:
> + d->type_reg_stride = chip->type_reg_stride ? : 1;
> +
Please don't abuse the ternery operator, especially not the GCC
extension - that's much less clear than just writing the if statement.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-05 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 12:55 Laxman Dewangan
2015-12-22 12:55 ` [PATCH 2/2] regmap: irq: add support to have callback pre/post irq handling Laxman Dewangan
2016-01-05 17:43 ` Mark Brown
2016-01-06 6:04 ` Laxman Dewangan
2016-01-05 17:41 ` Mark Brown [this message]
2016-01-06 5:48 ` [PATCH 1/2] regmap: irq: add support for configuration of trigger type Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105174114.GI6588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®