From: chenfeng <puck.chen@hisilicon.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee.jones@linaro.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <yudongbin@hisilicon.com>,
<saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
<kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
<z.liuxinliang@hisilicon.com>, <puck.chenfeng@gmail.com>,
<weidong2@hisilicon.com>, <w.f@huawei.com>,
<qijiwen@hisilicon.com>, <peter.panshilin@hisilicon.com>,
<dan.zhao@hisilicon.com>, <linuxarm@huawei.com>,
<liguozhu@hisilicon.com>, <shimingxing@hisilicon.com>,
<albert.lubing@hisilicon.com>, <oliver.fu@hisilicon.com>,
<haojian.zhuang@linaro.org>
Subject: Re: [PATCH v4 2/5] doc: bindings: Document for hi655x regulator driver
Date: Thu, 7 Jan 2016 11:36:13 +0800 [thread overview]
Message-ID: <568DDD2D.9050902@hisilicon.com> (raw)
In-Reply-To: <20160105154719.GC6588@sirena.org.uk>
On 2016/1/5 23:47, Mark Brown wrote:
> On Mon, Jan 04, 2016 at 08:27:49PM +0800, Chen Feng wrote:
>> Add Document for hi655x pmic regulator driver
>
> As indicated in the driver review this seems to be a bit of an unusual
> binding that I think needs reworking, also it needs a bit more detail -
> for example, listing which regulator names are valid.
>
> Please also use subject lines reflecting the normal style for the
> subsystem.
>
OK,Thanks.
next prev parent reply other threads:[~2016-01-07 3:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 12:27 [PATCH v4 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng
2016-01-04 12:27 ` [PATCH v4 1/5] doc: bindings: Add document for mfd hi665x PMIC Chen Feng
2016-01-04 12:27 ` [PATCH v4 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng
2016-01-05 15:47 ` Mark Brown
2016-01-07 3:36 ` chenfeng [this message]
2016-01-04 12:27 ` [PATCH v4 3/5] mfd: hi655x: Add hi665x pmic driver Chen Feng
2016-01-04 18:45 ` kbuild test robot
2016-01-04 20:02 ` kbuild test robot
2016-01-11 5:49 ` Lee Jones
2016-01-04 12:27 ` [PATCH v4 4/5] regulator: add regulator driver of hi655x pmic Chen Feng
2016-01-05 15:44 ` Mark Brown
2016-01-07 3:35 ` chenfeng
2016-01-04 12:27 ` [PATCH v4 5/5] hisilicon/dts: Add hi655x pmic dts node Chen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568DDD2D.9050902@hisilicon.com \
--to=puck.chen@hisilicon.com \
--cc=albert.lubing@hisilicon.com \
--cc=broonie@kernel.org \
--cc=dan.zhao@hisilicon.com \
--cc=haojian.zhuang@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=oliver.fu@hisilicon.com \
--cc=peter.panshilin@hisilicon.com \
--cc=puck.chenfeng@gmail.com \
--cc=qijiwen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=shimingxing@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=weidong2@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome