mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Joern Engel <joern@logfs.org>,
	Prasad Joshi <prasadjoshi.linux@gmail.com>,
	logfs@logfs.org, Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [PATCH] logfs: fix logfs build errors and dependencies
Date: Fri, 8 Jan 2016 11:25:50 -0800	[thread overview]
Message-ID: <56900D3E.50200@infradead.org> (raw)

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors that happen when CONFIG_LOGFS=y and CONFIG_MTD=m:

fs/built-in.o: In function `logfs_mount':
super.c:(.text+0x92a6f): undefined reference to `logfs_get_sb_mtd'
fs/built-in.o: In function `logfs_get_sb_bdev':
(.text+0x93530): undefined reference to `logfs_get_sb_mtd'

This change allows CONFIG_BLOCK and CONFIG_MTD to be disabled, but
if either of them is enabled, CONFIG_LOGFS is limited (restricted) by
the setting of the former symbol(s).

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc:	Joern Engel <joern@logfs.org>
Cc:	Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc:	logfs@logfs.org
---
 fs/logfs/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Found in linux-next but applies to mainline also.

--- linux-next-20160108.orig/fs/logfs/Kconfig
+++ linux-next-20160108/fs/logfs/Kconfig
@@ -1,6 +1,7 @@
 config LOGFS
 	tristate "LogFS file system"
-	depends on (MTD || BLOCK)
+	depends on BLOCK || BLOCK=n
+	depends on MTD || MTD=n
 	select ZLIB_INFLATE
 	select ZLIB_DEFLATE
 	select CRC32

                 reply	other threads:[~2016-01-08 19:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56900D3E.50200@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=joern@logfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logfs@logfs.org \
    --cc=prasadjoshi.linux@gmail.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome