From: chenfeng <puck.chen@hisilicon.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee.jones@linaro.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <yudongbin@hisilicon.com>,
<saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
<kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
<z.liuxinliang@hisilicon.com>, <weidong2@hisilicon.com>,
<w.f@huawei.com>, <puck.chen@foxmail.com>,
<shimingxing@hisilicon.com>, <oliver.fu@hisilicon.com>,
<albert.lubing@hisilicon.com>, <chenxiang9@huawei.com>,
<liuzixing@huawei.com>, <haojian.zhuang@linaro.org>,
<qijiwen@hisilicon.com>, <peter.panshilin@hisilicon.com>,
<dan.zhao@hisilicon.com>, <linuxarm@huawei.com>,
<dev@lists.96boards.org>
Subject: Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core
Date: Wed, 20 Jan 2016 11:51:27 +0800 [thread overview]
Message-ID: <569F043F.4040004@hisilicon.com> (raw)
In-Reply-To: <20160119173049.GQ6588@sirena.org.uk>
On 2016/1/20 1:30, Mark Brown wrote:
> On Tue, Jan 19, 2016 at 02:31:59PM +0800, Chen Feng wrote:
>
>> Chen Feng (5):
>> doc: bindings: Add document for mfd hi665x PMIC
>> doc: bindings: Document for hi655x regulator driver
>> mfd: hi655x: Add hi665x pmic driver
>> regulator: add regulator driver of hi655x pmic
>> hisilicon/dts: Add hi655x pmic dts node
>
> I've asked you several times to use subject lines reflecting the style
> for the subsystem for the DT bindings (and have just noticed that the
> same thing applies to the DTS update).
>
Mark,
Really sorry for this.
Since I have not caught what you mean before this time.
I changed the style problem from doc:bindings to doc: bindings.
A blank space added. But this was not accurately what you mean.
I will change it like this:
bindings: mfd: hi655x: Add document for mfd hi665x PMIC
bindings: regulator: hi655x: Document for hi655x regulator driver
regulator: hi655x: add regulator driver of hi655x pmic
arm64: dts: hisilicon: Add hi655x pmic dts node
Will this be okay?
Have you also reviewed the regulator driver code? I changed it to
of_match and regulators_node without opening code.
Thanks again for your advice.
Feng
next prev parent reply other threads:[~2016-01-20 3:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 6:31 Chen Feng
2016-01-19 6:32 ` [PATCH v6 1/5] doc: bindings: Add document for mfd hi665x PMIC Chen Feng
2016-01-19 6:32 ` [PATCH v6 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng
2016-01-19 6:32 ` [PATCH v6 3/5] mfd: hi655x: Add hi665x pmic driver Chen Feng
2016-01-19 6:32 ` [PATCH v6 4/5] regulator: add regulator driver of hi655x pmic Chen Feng
2016-01-19 6:32 ` [PATCH v6 5/5] hisilicon/dts: Add hi655x pmic dts node Chen Feng
2016-01-20 13:08 ` Mark Brown
2016-01-21 10:32 ` chenfeng
2016-01-21 22:11 ` Mark Brown
2016-01-19 17:30 ` [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Mark Brown
2016-01-20 3:51 ` chenfeng [this message]
2016-01-20 11:46 ` Mark Brown
2016-01-21 10:14 ` chenfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F043F.4040004@hisilicon.com \
--to=puck.chen@hisilicon.com \
--cc=albert.lubing@hisilicon.com \
--cc=broonie@kernel.org \
--cc=chenxiang9@huawei.com \
--cc=dan.zhao@hisilicon.com \
--cc=dev@lists.96boards.org \
--cc=haojian.zhuang@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuzixing@huawei.com \
--cc=oliver.fu@hisilicon.com \
--cc=peter.panshilin@hisilicon.com \
--cc=puck.chen@foxmail.com \
--cc=qijiwen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=shimingxing@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=weidong2@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome