From: chenfeng <puck.chen@hisilicon.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee.jones@linaro.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <yudongbin@hisilicon.com>,
<saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
<kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
<z.liuxinliang@hisilicon.com>, <weidong2@hisilicon.com>,
<w.f@huawei.com>, <puck.chen@foxmail.com>,
<shimingxing@hisilicon.com>, <oliver.fu@hisilicon.com>,
<albert.lubing@hisilicon.com>, <chenxiang9@huawei.com>,
<liuzixing@huawei.com>, <haojian.zhuang@linaro.org>,
<qijiwen@hisilicon.com>, <peter.panshilin@hisilicon.com>,
<dan.zhao@hisilicon.com>, <linuxarm@huawei.com>,
<dev@lists.96boards.org>
Subject: Re: [PATCH v6 5/5] hisilicon/dts: Add hi655x pmic dts node
Date: Thu, 21 Jan 2016 18:32:32 +0800 [thread overview]
Message-ID: <56A0B3C0.8030702@hisilicon.com> (raw)
In-Reply-To: <20160120130813.GD6588@sirena.org.uk>
Mark,
On 2016/1/20 21:08, Mark Brown wrote:
> On Tue, Jan 19, 2016 at 02:32:04PM +0800, Chen Feng wrote:
>
>> index 82d2488..6de9881 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>
>> + regulators {
>> + ldo2: ldo2@a21 {
>> + regulator-compatible = "LDO2";
>
I will change it like this:
regulators {
ldo2: LDO2@a21 {
regulator-name = "ldo2";
regulator-min-microvolt = <2500000>;
regulator-max-microvolt = <3200000>;
regulator-valid-modes-mask = <0x02>;
regulator-enable-ramp-delay = <120>;
};
> Why are you using the legacy regulator-compatible property? No new
> bindings should use this.
>
>> + regulator-min-microvolt = <2500000>;
>> + regulator-max-microvolt = <3200000>;
>
> This is broken as it misunderstands the purpose of specifying
> constraints. The constraints are there to say what the safe and
> supported configuration is on a given board, it is not possible to
> provide this information safely in a general include that is used by all
> systems using the PMIC. Specifying the maximum voltage range for the
> regulators is almost guaranteed to result in at least some
> configurations being enabled which will not work, in the worst case this
> may include configurations which could physically damage the system.
>
> In general it is very unusual to include the regulators in a .dtsi since
> essentially all the configuration for them should be board specific.
>
Do you mean that I should move this into dts and enable it by default?
next prev parent reply other threads:[~2016-01-21 10:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 6:31 [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng
2016-01-19 6:32 ` [PATCH v6 1/5] doc: bindings: Add document for mfd hi665x PMIC Chen Feng
2016-01-19 6:32 ` [PATCH v6 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng
2016-01-19 6:32 ` [PATCH v6 3/5] mfd: hi655x: Add hi665x pmic driver Chen Feng
2016-01-19 6:32 ` [PATCH v6 4/5] regulator: add regulator driver of hi655x pmic Chen Feng
2016-01-19 6:32 ` [PATCH v6 5/5] hisilicon/dts: Add hi655x pmic dts node Chen Feng
2016-01-20 13:08 ` Mark Brown
2016-01-21 10:32 ` chenfeng [this message]
2016-01-21 22:11 ` Mark Brown
2016-01-19 17:30 ` [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Mark Brown
2016-01-20 3:51 ` chenfeng
2016-01-20 11:46 ` Mark Brown
2016-01-21 10:14 ` chenfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A0B3C0.8030702@hisilicon.com \
--to=puck.chen@hisilicon.com \
--cc=albert.lubing@hisilicon.com \
--cc=broonie@kernel.org \
--cc=chenxiang9@huawei.com \
--cc=dan.zhao@hisilicon.com \
--cc=dev@lists.96boards.org \
--cc=haojian.zhuang@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuzixing@huawei.com \
--cc=oliver.fu@hisilicon.com \
--cc=peter.panshilin@hisilicon.com \
--cc=puck.chen@foxmail.com \
--cc=qijiwen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=shimingxing@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=weidong2@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome