* [PATCH] watchdog: imgdpc: select WATCHDOG_CORE
@ 2016-01-25 16:06 Arnd Bergmann
2016-01-25 16:17 ` James Hogan
2016-01-25 16:41 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-01-25 16:06 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: linux-arm-kernel, James Hogan, Andrew Bresticker,
Naidu Tellapati, Ezequiel Garcia, Arnd Bergmann, Guenter Roeck,
linux-watchdog, linux-kernel
The imgpdc_wdt driver can be built on all architectures with
CONFIG_COMPILE_TEST, but fails if no other watchdog driver is
enabled:
drivers/watchdog/built-in.o: In function `pdc_wdt_remove':
imgpdc_wdt.c:(.text+0x74): undefined reference to `watchdog_unregister_device'
This adds the normal 'select WATCHDOG_CORE' that is needed to
ensure the driver always builds cleanly.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 4f0e7be0da34..0dc61f1a552e 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1383,6 +1383,7 @@ config IMGPDC_WDT
tristate "Imagination Technologies PDC Watchdog Timer"
depends on HAS_IOMEM
depends on METAG || MIPS || COMPILE_TEST
+ select WATCHDOG_CORE
help
Driver for Imagination Technologies PowerDown Controller
Watchdog Timer.
--
2.7.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: imgdpc: select WATCHDOG_CORE
2016-01-25 16:06 [PATCH] watchdog: imgdpc: select WATCHDOG_CORE Arnd Bergmann
@ 2016-01-25 16:17 ` James Hogan
2016-01-25 16:41 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: James Hogan @ 2016-01-25 16:17 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Wim Van Sebroeck, linux-arm-kernel, Andrew Bresticker,
Naidu Tellapati, Ezequiel Garcia, Guenter Roeck, linux-watchdog,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
On Mon, Jan 25, 2016 at 05:06:27PM +0100, Arnd Bergmann wrote:
> The imgpdc_wdt driver can be built on all architectures with
> CONFIG_COMPILE_TEST, but fails if no other watchdog driver is
> enabled:
>
> drivers/watchdog/built-in.o: In function `pdc_wdt_remove':
> imgpdc_wdt.c:(.text+0x74): undefined reference to `watchdog_unregister_device'
>
> This adds the normal 'select WATCHDOG_CORE' that is needed to
> ensure the driver always builds cleanly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 4f0e7be0da34..0dc61f1a552e 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1383,6 +1383,7 @@ config IMGPDC_WDT
> tristate "Imagination Technologies PDC Watchdog Timer"
> depends on HAS_IOMEM
> depends on METAG || MIPS || COMPILE_TEST
> + select WATCHDOG_CORE
> help
> Driver for Imagination Technologies PowerDown Controller
> Watchdog Timer.
> --
> 2.7.0
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: imgdpc: select WATCHDOG_CORE
2016-01-25 16:06 [PATCH] watchdog: imgdpc: select WATCHDOG_CORE Arnd Bergmann
2016-01-25 16:17 ` James Hogan
@ 2016-01-25 16:41 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2016-01-25 16:41 UTC (permalink / raw)
To: Arnd Bergmann, Wim Van Sebroeck
Cc: linux-arm-kernel, James Hogan, Andrew Bresticker,
Naidu Tellapati, Ezequiel Garcia, linux-watchdog, linux-kernel
On 01/25/2016 08:06 AM, Arnd Bergmann wrote:
> The imgpdc_wdt driver can be built on all architectures with
> CONFIG_COMPILE_TEST, but fails if no other watchdog driver is
> enabled:
>
> drivers/watchdog/built-in.o: In function `pdc_wdt_remove':
> imgpdc_wdt.c:(.text+0x74): undefined reference to `watchdog_unregister_device'
>
> This adds the normal 'select WATCHDOG_CORE' that is needed to
> ensure the driver always builds cleanly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 4f0e7be0da34..0dc61f1a552e 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1383,6 +1383,7 @@ config IMGPDC_WDT
> tristate "Imagination Technologies PDC Watchdog Timer"
> depends on HAS_IOMEM
> depends on METAG || MIPS || COMPILE_TEST
> + select WATCHDOG_CORE
> help
> Driver for Imagination Technologies PowerDown Controller
> Watchdog Timer.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-25 16:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-25 16:06 [PATCH] watchdog: imgdpc: select WATCHDOG_CORE Arnd Bergmann
2016-01-25 16:17 ` James Hogan
2016-01-25 16:41 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome