From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/3] DT: add binding for SN3218 LED driver
Date: Mon, 01 Feb 2016 10:59:42 +0100 [thread overview]
Message-ID: <56AF2C8E.7030702@samsung.com> (raw)
In-Reply-To: <1454245156-15747-3-git-send-email-stefan.wahren@i2se.com>
On 01/31/2016 01:59 PM, Stefan Wahren wrote:
> This patch adds the binding for Si-En Technology SN3218
> 18-Channel LED driver.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/leds/leds-sn3218.txt | 42 ++++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-sn3218.txt b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
> new file mode 100644
> index 0000000..5daa9b0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
> @@ -0,0 +1,42 @@
> +* Si-En Technology - SN3218 18-Channel LED Driver
> +
> +Required properties:
> +- compatible :
> + "si-en,sn3218"
> +- address-cells : must be 1
> +- size-cells : must be 0
> +- reg : I2C slave address, typically 0x54
> +
> +There must be at least 1 LED which is represented as a sub-node
> +of the sn3218 device.
> +
> +LED sub-node properties:
> +- label : (optional) see Documentation/devicetree/bindings/leds/common.txt
> +- reg : number of LED line (could be from 0 to 17)
> +- linux,default-trigger : (optional)
> + see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +
> +sn3218: led-controller@54 {
> + compatible = "si-en,sn3218";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x54>;
> +
> + led@0 {
> + label = "led1";
> + reg = <0x0>;
> + };
> +
> + led@1 {
> + label = "led2";
> + reg = <0x1>;
> + };
> +
> + led@2 {
> + label = "led3";
> + reg = <0x2>;
> + };
> +};
> +
Please remove this empty line.
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-02-01 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 12:59 [PATCH 0/3] leds: add " Stefan Wahren
2016-01-31 12:59 ` [PATCH 1/3] of: Add vendor prefix for Si-En Technology Stefan Wahren
2016-01-31 12:59 ` [PATCH 2/3] DT: add binding for SN3218 LED driver Stefan Wahren
2016-02-01 9:59 ` Jacek Anaszewski [this message]
2016-01-31 12:59 ` [PATCH 3/3] leds: add " Stefan Wahren
2016-02-01 9:58 ` Jacek Anaszewski
2016-02-01 12:53 ` Jacek Anaszewski
2016-02-01 13:20 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF2C8E.7030702@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome