mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Philipp Hahn <pmhahn@pmhahn.de>,
	Sasha Levin <sasha.levin@oracle.com>,
	Rainer Weikusat <rweikusat@mobileactivedefense.com>,
	Andrey Vagin <avagin@openvz.org>,
	Aaron Conole <aconole@bytheb.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Bug 4.1.16: self-detected stall in net/unix/?
Date: Wed, 3 Feb 2016 02:43:14 +0100	[thread overview]
Message-ID: <56B15B32.1020701@stressinduktion.org> (raw)
In-Reply-To: <56B0D88A.1020609@pmhahn.de>

On 02.02.2016 17:25, Philipp Hahn wrote:
> Hi,
>
> we recently updated our kernel to 4.1.16 + patch for "unix: properly
> account for FDs passed over unix sockets" and have since then
> self-detected stalls triggered by the Samba daemon:
>
 > >
 > > [...]
 > >
>
> We have not yet been able to reproduce the hang, but going back to our
> previous kernel 4.1.12 makes the problem go away.

Can you remove the patch "unix: properly account for FDs passed over 
unix sockets" and see if the problem still happens?

I couldn't quickly see any problems with your added patch. I currently 
suspect a tight loop because of a SOCK_DEAD flag set but the socket not 
removed from unix_socket_table or the vfs. Hmmm...

The stack trace is rather unreliable, maybe something completely 
different happend. Do you happend to see better reports?

> Is this a known issue or do you have an idea where to look?
> What information should I collect next time it happens?
>
> (Can unix_diag.ko with `ss` help?)

Would be interesting if it is a conventional file based socket or 
autobounded one (sun_path[0] != '\0').

Thanks,
Hannes

  reply	other threads:[~2016-02-03  1:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 16:25 Philipp Hahn
2016-02-03  1:43 ` Hannes Frederic Sowa [this message]
2016-02-05 15:28   ` Philipp Hahn
2016-02-11 13:47     ` Philipp Hahn
2016-02-11 15:55       ` Rainer Weikusat
2016-02-11 17:03         ` Ben Hutchings
2016-02-11 17:40           ` Rainer Weikusat
2016-02-11 17:54             ` Rainer Weikusat
2016-02-11 18:31             ` Rainer Weikusat
2016-02-11 19:37               ` [PATCH net] af_unix: Guard against other == sk in unix_dgram_sendmsg Rainer Weikusat
2016-02-12  9:19                 ` Philipp Hahn
2016-02-12 13:25                   ` Rainer Weikusat
2016-02-12 19:54                     ` Ben Hutchings
2016-02-12 20:17                       ` Rainer Weikusat
2016-02-12 20:47                         ` Ben Hutchings
2016-02-12 20:59                           ` Rainer Weikusat
2016-02-16 17:54                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B15B32.1020701@stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=aconole@bytheb.org \
    --cc=avagin@openvz.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmhahn@pmhahn.de \
    --cc=rweikusat@mobileactivedefense.com \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome