* Left-over select to PUBLIC_KEY_ALGO_RSA
@ 2016-03-04 15:17 Andreas Ziegler
2016-03-04 15:23 ` David Howells
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Ziegler @ 2016-03-04 15:17 UTC (permalink / raw)
To: David Howells
Cc: Tadeusz Struk, Herbert Xu, Valentin Rothberg, linux-kernel,
linux-crypto, linux-security-module
Hi David,
your patch "akcipher: Move the RSA DER encoding check to the crypto
layer" showed up in linux-next today as commit d43de6c780a8 (that is,
next-20160304).
It removes the CONFIG_PUBLIC_KEY_ALGO_RSA option, but does leave one
reference to it in place inside security/integrity/Kconfig, in the
definition of CONFIG_INTEGRITY_ASYMMETRIC_KEYS.
As the corresponding option is gone, the select statement can safely be
removed. Should I prepare a simple patch for that?
I detected this by using scripts/checkkconfigsymbols on today's and
yesterday's linux-next trees (i.e., "./scripts/checkkconfigsymbols.py -d
next-20160303..next-20160304").
Best regards,
Andreas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Left-over select to PUBLIC_KEY_ALGO_RSA
2016-03-04 15:17 Left-over select to PUBLIC_KEY_ALGO_RSA Andreas Ziegler
@ 2016-03-04 15:23 ` David Howells
2016-03-04 18:00 ` [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA Andreas Ziegler
2016-03-07 14:59 ` David Howells
0 siblings, 2 replies; 4+ messages in thread
From: David Howells @ 2016-03-04 15:23 UTC (permalink / raw)
To: Andreas Ziegler
Cc: dhowells, Tadeusz Struk, Herbert Xu, Valentin Rothberg,
linux-kernel, linux-crypto, linux-security-module
Andreas Ziegler <andreas.ziegler@fau.de> wrote:
> As the corresponding option is gone, the select statement can safely be
> removed. Should I prepare a simple patch for that?
Please.
> I detected this by using scripts/checkkconfigsymbols on today's and
> yesterday's linux-next trees (i.e., "./scripts/checkkconfigsymbols.py -d
> next-20160303..next-20160304").
Interesting - I didn't realise that exists. This sort of consistency check
should be run every time the Kconfig files are parsed.
Thanks,
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA
2016-03-04 15:23 ` David Howells
@ 2016-03-04 18:00 ` Andreas Ziegler
2016-03-07 14:59 ` David Howells
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Ziegler @ 2016-03-04 18:00 UTC (permalink / raw)
To: James Morris
Cc: Serge E. Hallyn, David Howells, Herbert Xu, Tadeusz Struk,
linux-security-module, linux-crypto, linux-kernel,
Valentin Rothberg, Andreas Ziegler
Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to
the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA,
but forgot to remove a 'select' to this option in the definition of
INTEGRITY_ASYMMETRIC_KEYS.
Let's remove the select, as it's ineffective now.
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
security/integrity/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 979be65..da95658 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -35,7 +35,6 @@ config INTEGRITY_ASYMMETRIC_KEYS
default n
select ASYMMETRIC_KEY_TYPE
select ASYMMETRIC_PUBLIC_KEY_SUBTYPE
- select PUBLIC_KEY_ALGO_RSA
select CRYPTO_RSA
select X509_CERTIFICATE_PARSER
help
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA
2016-03-04 15:23 ` David Howells
2016-03-04 18:00 ` [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA Andreas Ziegler
@ 2016-03-07 14:59 ` David Howells
1 sibling, 0 replies; 4+ messages in thread
From: David Howells @ 2016-03-07 14:59 UTC (permalink / raw)
To: Andreas Ziegler
Cc: dhowells, James Morris, Serge E. Hallyn, Herbert Xu,
Tadeusz Struk, linux-security-module, linux-crypto, linux-kernel,
Valentin Rothberg
Andreas Ziegler <andreas.ziegler@fau.de> wrote:
> Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to
> the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA,
> but forgot to remove a 'select' to this option in the definition of
> INTEGRITY_ASYMMETRIC_KEYS.
>
> Let's remove the select, as it's ineffective now.
>
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-07 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-04 15:17 Left-over select to PUBLIC_KEY_ALGO_RSA Andreas Ziegler
2016-03-04 15:23 ` David Howells
2016-03-04 18:00 ` [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA Andreas Ziegler
2016-03-07 14:59 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®