From: "Christian Kohlschütter" <christian@kohlschutter.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
overlayfs <linux-unionfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] [REGRESSION] ovl: Handle ENOSYS when fileattr support is missing in lower/upper fs
Date: Mon, 18 Jul 2022 22:33:48 +0200 [thread overview]
Message-ID: <56E6CAAE-FF25-4898-8F9D-048164582E7B@kohlschutter.com> (raw)
In-Reply-To: <CAHk-=wg+bpP5cvcaBhnmJKzTmAtgx12UhR4qzFXXb52atn9gDw@mail.gmail.com>
> Am 18.07.2022 um 22:12 schrieb Linus Torvalds <torvalds@linux-foundation.org>:
>
> On Mon, Jul 18, 2022 at 12:28 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
>>
>> So this is a bug in the kernel part of fuse, that doesn't catch and
>> convert ENOSYS in case of the ioctl request.
>
> Ahh, even better. No need to worry about external issues.
>
> Linus
My concern was fixing it in fuse instead of ovl would leave non-fuse filesystems affected (even though I don't have proof that such filesystems exist).
I'm glad you are OK with Miklos' change; the outcome of this discussion certainly adds some nuance to the famous "don't break userspace" / error code thread from 2012.
Best,
Christian
next prev parent reply other threads:[~2022-07-18 20:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 18:36 [PATCH] " Christian Kohlschütter
2022-07-18 9:14 ` Miklos Szeredi
2022-07-18 10:10 ` Christian Kohlschütter
2022-07-18 10:31 ` Miklos Szeredi
2022-07-18 10:56 ` Christian Kohlschütter
2022-07-18 12:21 ` Miklos Szeredi
2022-07-18 13:03 ` [PATCH] [REGRESSION] " Christian Kohlschütter
2022-07-18 13:13 ` Miklos Szeredi
2022-07-18 14:25 ` Christian Kohlschütter
2022-07-18 15:02 ` Antonio SJ Musumeci
2022-07-18 17:23 ` Miklos Szeredi
2022-07-18 18:29 ` Linus Torvalds
2022-07-18 19:04 ` Christian Kohlschütter
2022-07-18 19:17 ` Linus Torvalds
2022-07-18 19:27 ` Miklos Szeredi
2022-07-18 20:12 ` Linus Torvalds
2022-07-18 20:33 ` Christian Kohlschütter [this message]
2023-01-18 3:41 ` Jonathan Katz
2023-01-26 13:26 ` Miklos Szeredi
2023-01-30 19:27 ` Jonathan Katz
2023-02-23 23:11 ` Jonathan Katz
2023-03-07 1:12 ` Jonathan Katz
2023-03-07 8:38 ` Miklos Szeredi
2023-03-07 17:14 ` Jonathan Katz
2023-03-09 15:31 ` Miklos Szeredi
2023-03-15 1:51 ` Jonathan Katz
2023-03-15 2:43 ` Jonathan Katz
2023-03-22 18:42 ` Jonathan Katz
2023-04-21 14:26 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E6CAAE-FF25-4898-8F9D-048164582E7B@kohlschutter.com \
--to=christian@kohlschutter.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®