[PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe

[PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe

[Wolfram Sang]

Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from
device core"), we can rely on device core for setting the default pins.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 9aefd010acde..68093d6b6b16 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -6,7 +6,6 @@
 
 #include <linux/backlight.h>
 #include <linux/gpio/consumer.h>
-#include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
 
 #include <video/display_timing.h>
@@ -308,7 +307,6 @@ static int panel_probe(struct platform_device *pdev)
 	struct backlight_device *backlight;
 	struct panel_module *panel_mod;
 	struct tilcdc_module *mod;
-	struct pinctrl *pinctrl;
 	int ret;
 
 	/* bail out early if no DT data: */
@@ -342,10 +340,6 @@ static int panel_probe(struct platform_device *pdev)
 
 	tilcdc_module_init(mod, "panel", &panel_module_ops);
 
-	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
-	if (IS_ERR(pinctrl))
-		dev_warn(&pdev->dev, "pins are not configured\n");
-
 	panel_mod->timings = of_get_display_timings(node);
 	if (!panel_mod->timings) {
 		dev_err(&pdev->dev, "could not get panel timings\n");
-- 
2.30.2

Re: [PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe

[Geert Uytterhoeven]

CC pinctrl

On Fri, Sep 22, 2023 at 6:26 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from
> device core"), we can rely on device core for setting the default pins.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -6,7 +6,6 @@
>
>  #include <linux/backlight.h>
>  #include <linux/gpio/consumer.h>
> -#include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
>
>  #include <video/display_timing.h>
> @@ -308,7 +307,6 @@ static int panel_probe(struct platform_device *pdev)
>         struct backlight_device *backlight;
>         struct panel_module *panel_mod;
>         struct tilcdc_module *mod;
> -       struct pinctrl *pinctrl;
>         int ret;
>
>         /* bail out early if no DT data: */
> @@ -342,10 +340,6 @@ static int panel_probe(struct platform_device *pdev)
>
>         tilcdc_module_init(mod, "panel", &panel_module_ops);
>
> -       pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> -       if (IS_ERR(pinctrl))
> -               dev_warn(&pdev->dev, "pins are not configured\n");
> -
>         panel_mod->timings = of_get_display_timings(node);
>         if (!panel_mod->timings) {
>                 dev_err(&pdev->dev, "could not get panel timings\n");

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe

[Tomi Valkeinen]

On 22/09/2023 10:37, Wolfram Sang wrote:
> Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from
> device core"), we can rely on device core for setting the default pins.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>   drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 9aefd010acde..68093d6b6b16 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -6,7 +6,6 @@
>   
>   #include <linux/backlight.h>
>   #include <linux/gpio/consumer.h>
> -#include <linux/pinctrl/consumer.h>
>   #include <linux/platform_device.h>
>   
>   #include <video/display_timing.h>
> @@ -308,7 +307,6 @@ static int panel_probe(struct platform_device *pdev)
>   	struct backlight_device *backlight;
>   	struct panel_module *panel_mod;
>   	struct tilcdc_module *mod;
> -	struct pinctrl *pinctrl;
>   	int ret;
>   
>   	/* bail out early if no DT data: */
> @@ -342,10 +340,6 @@ static int panel_probe(struct platform_device *pdev)
>   
>   	tilcdc_module_init(mod, "panel", &panel_module_ops);
>   
> -	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> -	if (IS_ERR(pinctrl))
> -		dev_warn(&pdev->dev, "pins are not configured\n");
> -
>   	panel_mod->timings = of_get_display_timings(node);
>   	if (!panel_mod->timings) {
>   		dev_err(&pdev->dev, "could not get panel timings\n");

Thanks, applying to drm-misc-next.

  Tomi