* [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64
@ 2024-09-19 7:25 Enlin Mu
2024-09-19 7:51 ` Baolin Wang
2024-10-28 15:19 ` Daniel Lezcano
0 siblings, 2 replies; 5+ messages in thread
From: Enlin Mu @ 2024-09-19 7:25 UTC (permalink / raw)
To: daniel.lezcano, tglx, orsonzhai, baolin.wang, zhang.lyra,
linux-kernel, enlin.mu, enlinmu
Cc: linux-hardening
From: Enlin Mu <enlin.mu@unisoc.com>
sprd timer is currently available on ARM and ARM64 based devices.
Thus select it for ARM and ARM64
Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
---
drivers/clocksource/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 95dd4660b5b6..296c5f664583 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -494,8 +494,8 @@ config MTK_CPUX_TIMER
config SPRD_TIMER
bool "Spreadtrum timer driver" if EXPERT
depends on HAS_IOMEM
- depends on (ARCH_SPRD || COMPILE_TEST)
- default ARCH_SPRD
+ depends on (ARM || ARM64 || COMPILE_TEST)
+ default y
select TIMER_OF
help
Enables support for the Spreadtrum timer driver.
--
2.39.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64
2024-09-19 7:25 [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64 Enlin Mu
@ 2024-09-19 7:51 ` Baolin Wang
2024-09-20 1:47 ` Chunyan Zhang
2024-10-28 15:19 ` Daniel Lezcano
1 sibling, 1 reply; 5+ messages in thread
From: Baolin Wang @ 2024-09-19 7:51 UTC (permalink / raw)
To: Enlin Mu, daniel.lezcano, tglx, orsonzhai, zhang.lyra,
linux-kernel, enlin.mu, enlinmu
Cc: linux-hardening
On 2024/9/19 15:25, Enlin Mu wrote:
> From: Enlin Mu <enlin.mu@unisoc.com>
>
> sprd timer is currently available on ARM and ARM64 based devices.
> Thus select it for ARM and ARM64
>
> Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
> ---
> drivers/clocksource/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 95dd4660b5b6..296c5f664583 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -494,8 +494,8 @@ config MTK_CPUX_TIMER
> config SPRD_TIMER
> bool "Spreadtrum timer driver" if EXPERT
> depends on HAS_IOMEM
> - depends on (ARCH_SPRD || COMPILE_TEST)
> - default ARCH_SPRD
> + depends on (ARM || ARM64 || COMPILE_TEST)
I don't understand, if this driver is available on ARM, why ARCH_SPRD is
not enabled on ARM architecture?
> + default y
> select TIMER_OF
> help
> Enables support for the Spreadtrum timer driver.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64
2024-09-19 7:51 ` Baolin Wang
@ 2024-09-20 1:47 ` Chunyan Zhang
2024-09-20 7:00 ` Cixi Geng
0 siblings, 1 reply; 5+ messages in thread
From: Chunyan Zhang @ 2024-09-20 1:47 UTC (permalink / raw)
To: Baolin Wang
Cc: Enlin Mu, daniel.lezcano, tglx, orsonzhai, linux-kernel,
enlin.mu, enlinmu, linux-hardening
On Thu, 19 Sept 2024 at 15:51, Baolin Wang
<baolin.wang@linux.alibaba.com> wrote:
>
>
>
> On 2024/9/19 15:25, Enlin Mu wrote:
> > From: Enlin Mu <enlin.mu@unisoc.com>
> >
> > sprd timer is currently available on ARM and ARM64 based devices.
> > Thus select it for ARM and ARM64
> >
> > Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
> > ---
> > drivers/clocksource/Kconfig | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > index 95dd4660b5b6..296c5f664583 100644
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -494,8 +494,8 @@ config MTK_CPUX_TIMER
> > config SPRD_TIMER
> > bool "Spreadtrum timer driver" if EXPERT
> > depends on HAS_IOMEM
> > - depends on (ARCH_SPRD || COMPILE_TEST)
> > - default ARCH_SPRD
> > + depends on (ARM || ARM64 || COMPILE_TEST)
>
> I don't understand, if this driver is available on ARM, why ARCH_SPRD is
> not enabled on ARM architecture?
It is probably because GKI doesn't select ARCH_SPRD.
>
> > + default y
> > select TIMER_OF
> > help
> > Enables support for the Spreadtrum timer driver.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64
2024-09-20 1:47 ` Chunyan Zhang
@ 2024-09-20 7:00 ` Cixi Geng
0 siblings, 0 replies; 5+ messages in thread
From: Cixi Geng @ 2024-09-20 7:00 UTC (permalink / raw)
To: Chunyan Zhang, cixi.geng
Cc: Baolin Wang, Enlin Mu, daniel.lezcano, tglx, orsonzhai,
linux-kernel, enlin.mu, enlinmu, linux-hardening
Chunyan Zhang <zhang.lyra@gmail.com> 于2024年9月20日周五 09:48写道:
>
> On Thu, 19 Sept 2024 at 15:51, Baolin Wang
> <baolin.wang@linux.alibaba.com> wrote:
> >
> >
> >
> > On 2024/9/19 15:25, Enlin Mu wrote:
> > > From: Enlin Mu <enlin.mu@unisoc.com>
> > >
> > > sprd timer is currently available on ARM and ARM64 based devices.
> > > Thus select it for ARM and ARM64
> > >
> > > Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
> > > ---
> > > drivers/clocksource/Kconfig | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > > index 95dd4660b5b6..296c5f664583 100644
> > > --- a/drivers/clocksource/Kconfig
> > > +++ b/drivers/clocksource/Kconfig
> > > @@ -494,8 +494,8 @@ config MTK_CPUX_TIMER
> > > config SPRD_TIMER
> > > bool "Spreadtrum timer driver" if EXPERT
> > > depends on HAS_IOMEM
> > > - depends on (ARCH_SPRD || COMPILE_TEST)
> > > - default ARCH_SPRD
> > > + depends on (ARM || ARM64 || COMPILE_TEST)
> >
> > I don't understand, if this driver is available on ARM, why ARCH_SPRD is
> > not enabled on ARM architecture?
the ARCH_SPRD is not enabled on ARM by default for some other configs
will enabled at same time.
we just need the SPRD_TIMER
>
> It is probably because GKI doesn't select ARCH_SPRD.
>
>
> >
> > > + default y
> > > select TIMER_OF
> > > help
> > > Enables support for the Spreadtrum timer driver.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64
2024-09-19 7:25 [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64 Enlin Mu
2024-09-19 7:51 ` Baolin Wang
@ 2024-10-28 15:19 ` Daniel Lezcano
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2024-10-28 15:19 UTC (permalink / raw)
To: Enlin Mu, tglx, orsonzhai, baolin.wang, zhang.lyra, linux-kernel,
enlin.mu, enlinmu
Cc: linux-hardening
On 19/09/2024 09:25, Enlin Mu wrote:
> From: Enlin Mu <enlin.mu@unisoc.com>
>
> sprd timer is currently available on ARM and ARM64 based devices.
> Thus select it for ARM and ARM64
Can you answer Baolin's question ?
Or can you tell what is the rational behind this change ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-28 15:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-19 7:25 [PATCH] clocksource/drivers/timer-sprd: Select driver on ARM and ARM64 Enlin Mu
2024-09-19 7:51 ` Baolin Wang
2024-09-20 1:47 ` Chunyan Zhang
2024-09-20 7:00 ` Cixi Geng
2024-10-28 15:19 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®