* [PATCH] crypto: ccp: Don't initialize CCP for PSP 0x1649
@ 2023-04-03 17:38 Mario Limonciello
2023-04-03 17:55 ` Tom Lendacky
2023-04-14 11:05 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Mario Limonciello @ 2023-04-03 17:38 UTC (permalink / raw)
To: Tom Lendacky, John Allen
Cc: Mario Limonciello, stable, Herbert Xu, David S. Miller,
linux-crypto, linux-kernel
A number of platforms are emitting the error:
```ccp: unable to access the device: you might be running a broken BIOS.```
This is expected behavior as CCP is no longer accessible from the PSP's
PCIe BAR so stop trying to probe CCP for 0x1649.
Cc: stable@vger.kernel.org
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/crypto/ccp/sp-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
index 084d052fddcc..55411b494d69 100644
--- a/drivers/crypto/ccp/sp-pci.c
+++ b/drivers/crypto/ccp/sp-pci.c
@@ -451,9 +451,9 @@ static const struct pci_device_id sp_pci_table[] = {
{ PCI_VDEVICE(AMD, 0x1468), (kernel_ulong_t)&dev_vdata[2] },
{ PCI_VDEVICE(AMD, 0x1486), (kernel_ulong_t)&dev_vdata[3] },
{ PCI_VDEVICE(AMD, 0x15DF), (kernel_ulong_t)&dev_vdata[4] },
- { PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[4] },
{ PCI_VDEVICE(AMD, 0x14CA), (kernel_ulong_t)&dev_vdata[5] },
{ PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
+ { PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[6] },
/* Last entry must be zero */
{ 0, }
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: ccp: Don't initialize CCP for PSP 0x1649
2023-04-03 17:38 [PATCH] crypto: ccp: Don't initialize CCP for PSP 0x1649 Mario Limonciello
@ 2023-04-03 17:55 ` Tom Lendacky
2023-04-14 11:05 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Tom Lendacky @ 2023-04-03 17:55 UTC (permalink / raw)
To: Mario Limonciello, John Allen
Cc: stable, Herbert Xu, David S. Miller, linux-crypto, linux-kernel
On 4/3/23 12:38, Mario Limonciello wrote:
> A number of platforms are emitting the error:
> ```ccp: unable to access the device: you might be running a broken BIOS.```
>
> This is expected behavior as CCP is no longer accessible from the PSP's
> PCIe BAR so stop trying to probe CCP for 0x1649.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/crypto/ccp/sp-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 084d052fddcc..55411b494d69 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -451,9 +451,9 @@ static const struct pci_device_id sp_pci_table[] = {
> { PCI_VDEVICE(AMD, 0x1468), (kernel_ulong_t)&dev_vdata[2] },
> { PCI_VDEVICE(AMD, 0x1486), (kernel_ulong_t)&dev_vdata[3] },
> { PCI_VDEVICE(AMD, 0x15DF), (kernel_ulong_t)&dev_vdata[4] },
> - { PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[4] },
> { PCI_VDEVICE(AMD, 0x14CA), (kernel_ulong_t)&dev_vdata[5] },
> { PCI_VDEVICE(AMD, 0x15C7), (kernel_ulong_t)&dev_vdata[6] },
> + { PCI_VDEVICE(AMD, 0x1649), (kernel_ulong_t)&dev_vdata[6] },
> /* Last entry must be zero */
> { 0, }
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: ccp: Don't initialize CCP for PSP 0x1649
2023-04-03 17:38 [PATCH] crypto: ccp: Don't initialize CCP for PSP 0x1649 Mario Limonciello
2023-04-03 17:55 ` Tom Lendacky
@ 2023-04-14 11:05 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2023-04-14 11:05 UTC (permalink / raw)
To: Mario Limonciello
Cc: Tom Lendacky, John Allen, stable, David S. Miller, linux-crypto,
linux-kernel
On Mon, Apr 03, 2023 at 12:38:01PM -0500, Mario Limonciello wrote:
> A number of platforms are emitting the error:
> ```ccp: unable to access the device: you might be running a broken BIOS.```
>
> This is expected behavior as CCP is no longer accessible from the PSP's
> PCIe BAR so stop trying to probe CCP for 0x1649.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/crypto/ccp/sp-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-14 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-03 17:38 [PATCH] crypto: ccp: Don't initialize CCP for PSP 0x1649 Mario Limonciello
2023-04-03 17:55 ` Tom Lendacky
2023-04-14 11:05 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®