mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Floris Kraak <randakar@gmail.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Roland Dreier <rdreier@cisco.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Trivial Patch Monkey <trivial@kernel.org>
Subject: Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag
Date: Tue, 10 Feb 2009 22:48:52 +0100	[thread overview]
Message-ID: <56e1b5710902101348h5ae7b98bk97a69b2718f22bb1@mail.gmail.com> (raw)
In-Reply-To: <20090210202405.GB1382@ucw.cz>

On Tue, Feb 10, 2009 at 9:24 PM, Pavel Machek <pavel@suse.cz> wrote:
> On Wed 2009-02-04 14:26:45, Roland Dreier wrote:
>>  > Before judging on this patch could you please post what warning it
>>  > triggers and one or a few patches to fix some of them.
>>
>> The warnings are things like:
>>
>>     init/main.c: In function 'start_kernel':
>>     init/main.c:557: warning: format not a string literal and no format arguments
>>
>
> Would it be possible to declare linux_banner const or something?
>
>> diff --git a/init/main.c b/init/main.c
>> index 8442094..78fc0d8 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -554,7 +554,7 @@ asmlinkage void __init start_kernel(void)
>>       boot_cpu_init();
>>       page_address_init();
>>       printk(KERN_NOTICE);
>> -     printk(linux_banner);
>> +     printk("%s", linux_banner);
>
> Actually
>         printk(KERN_NOTICE "%s", linux_banner);
>
> is a better fix that will save some code, too.
>

Noted. Adding that to the patch tomorrow.

Regards,
Floris
---
"They that give up essential liberty to obtain temporary safety,
deserve neither liberty nor safety."
  -- Ben Franklin

"The course of history shows that as a government grows, liberty
decreases."
  -- Thomas Jefferson

  reply	other threads:[~2009-02-10 21:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 14:28 Floris Kraak
2009-02-04 22:14 ` Sam Ravnborg
2009-02-04 22:26   ` Roland Dreier
2009-02-04 23:48     ` Robert Hancock
2009-02-05  6:37       ` Roland Dreier
2009-02-05  8:26         ` Floris Kraak
2009-02-05 10:15           ` Floris Kraak
2009-02-05 10:27             ` Andreas Schwab
2009-02-05 10:50               ` Floris Kraak
2009-02-05 21:52               ` Roland Dreier
2009-02-10 21:11           ` Kyle Moffett
2009-02-10 21:56             ` Floris Kraak
2009-02-10 20:24     ` Pavel Machek
2009-02-10 21:48       ` Floris Kraak [this message]
2009-05-15 10:23 ` Pekka Enberg
2009-05-15 13:28   ` Floris Kraak
2009-05-15 20:42     ` Pekka Enberg
2009-05-15 22:09       ` Floris Kraak
2009-06-14 20:50     ` Sam Ravnborg
2009-06-15  5:54       ` Pekka J Enberg
2009-06-15  8:02         ` Floris Kraak
2009-06-26 22:15         ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56e1b5710902101348h5ae7b98bk97a69b2718f22bb1@mail.gmail.com \
    --to=randakar@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    --cc=rdreier@cisco.com \
    --cc=sam@ravnborg.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®