From: Andreas Schwab <schwab@suse.de>
To: Floris Kraak <randakar@gmail.com>
Cc: Roland Dreier <rdreier@cisco.com>,
Robert Hancock <hancockrwd@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Trivial Patch Monkey <trivial@kernel.org>
Subject: Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag
Date: Thu, 05 Feb 2009 11:27:10 +0100 [thread overview]
Message-ID: <jeab91w54x.fsf@sykes.suse.de> (raw)
In-Reply-To: <56e1b5710902050215l5b34adb1ofb8a972318ebe353@mail.gmail.com> (Floris Kraak's message of "Thu, 5 Feb 2009 11:15:12 +0100")
Floris Kraak <randakar@gmail.com> writes:
> Example:
>
> kernel/power/main.c:717: warning: format not a string literal and no
> format arguments
>
> This complains about:
> ..
> if (!rtc) {
> printk(warn_no_rtc);
> goto done;
> }
> ..
>
> So what is this "warn_no_rtc" thing?
>
> static char warn_no_rtc[] __initdata =
> KERN_WARNING "PM: no wakealarm-capable RTC driver is ready\n";
Does it help to make it const?
> That's pretty much GCC failing to recognize that the format is a
> string literal and then complaining that it isn't.
Since it's a non-const variable it cannot be a string literal.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-02-05 10:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 14:28 Floris Kraak
2009-02-04 22:14 ` Sam Ravnborg
2009-02-04 22:26 ` Roland Dreier
2009-02-04 23:48 ` Robert Hancock
2009-02-05 6:37 ` Roland Dreier
2009-02-05 8:26 ` Floris Kraak
2009-02-05 10:15 ` Floris Kraak
2009-02-05 10:27 ` Andreas Schwab [this message]
2009-02-05 10:50 ` Floris Kraak
2009-02-05 21:52 ` Roland Dreier
2009-02-10 21:11 ` Kyle Moffett
2009-02-10 21:56 ` Floris Kraak
2009-02-10 20:24 ` Pavel Machek
2009-02-10 21:48 ` Floris Kraak
2009-05-15 10:23 ` Pekka Enberg
2009-05-15 13:28 ` Floris Kraak
2009-05-15 20:42 ` Pekka Enberg
2009-05-15 22:09 ` Floris Kraak
2009-06-14 20:50 ` Sam Ravnborg
2009-06-15 5:54 ` Pekka J Enberg
2009-06-15 8:02 ` Floris Kraak
2009-06-26 22:15 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jeab91w54x.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hancockrwd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randakar@gmail.com \
--cc=rdreier@cisco.com \
--cc=sam@ravnborg.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome