From: m18063 <Claudiu.Beznea@Microchip.com>
To: "Yang, Wenyou" <Wenyou.Yang@Microchip.com>,
<nicolas.ferre@Microchip.com>,
<alexandre.belloni@free-electrons.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <linux@armlinux.org.uk>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Wenyou Yang <wenyou.yang@atmel.com>
Subject: Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic.
Date: Tue, 10 Oct 2017 13:09:32 +0300 [thread overview]
Message-ID: <5714eb53-d777-130e-b8bd-f80eda7c96b0@microchip.com> (raw)
In-Reply-To: <d42b60fb-7eac-229c-5e71-303e271c01a0@Microchip.com>
Hi Wenyou,
On 10.10.2017 03:39, Yang, Wenyou wrote:
> Hi Claudiu,
>
>
> On 2017/10/10 0:09, Claudiu Beznea wrote:
>> Add charger device node as a sub-device node of act8945a mfd, move
>> the charger's properties to this node, and use the "interrupts"
>> property to replace "active-semi,irq_gpios" to denote the act8945a
>> charger's irq.
>>
>> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
>> [claudiu.beznea@microchip.com: replace numbers with pin macros]
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> This patch has already applied on at91-dt branch.
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=at91-dt&id=4b6ad41f267b8ddabf5dd1b02a318bc74f0b95e9
>
Thanks, I will remove it from v2.
>> ---
>> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 23 +++++++++++++++--------
>> 1 file changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> index c7e9ccf2bc87..848ca1b025be 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> @@ -160,14 +160,6 @@
>> compatible = "active-semi,act8945a";
>> reg = <0x5b>;
>> active-semi,vsel-high;
>> - active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
>> - active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
>> - active-semi,irq_gpios = <&pioA PIN_PB13 GPIO_ACTIVE_LOW>;
>> - active-semi,input-voltage-threshold-microvolt = <6600>;
>> - active-semi,precondition-timeout = <40>;
>> - active-semi,total-timeout = <3>;
>> - pinctrl-names = "default";
>> - pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
>> status = "okay";
>> regulators {
>> @@ -220,6 +212,21 @@
>> regulator-always-on;
>> };
>> };
>> +
>> + charger {
>> + compatible = "active-semi,act8945a-charger";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
>> + interrupt-parent = <&pioA>;
>> + interrupts = <PIN_PB13 GPIO_ACTIVE_LOW>;
>> +
>> + active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
>> + active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
>> + active-semi,input-voltage-threshold-microvolt = <6600>;
>> + active-semi,precondition-timeout = <40>;
>> + active-semi,total-timeout = <3>;
>> + status = "okay";
>> + };
>> };
>> };
>>
>
> Best Regards,
> Wenyou Yang
next prev parent reply other threads:[~2017-10-10 10:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 16:09 [PATCH 00/14] at91 fixes and enhancements Claudiu Beznea
2017-10-09 16:09 ` [PATCH 01/15] ARM: dts: at91: sama5d27_som1_ek: add disabled status Claudiu Beznea
2017-10-09 16:09 ` [PATCH 02/15] ARM: dts: at91: sama5d27_som1_ek: enable i2c2 Claudiu Beznea
2017-10-09 16:09 ` [PATCH 03/15] ARM: dts: at91: sama5d27_som1_ek: update serial aliases Claudiu Beznea
2017-10-09 16:09 ` [PATCH 04/15] ARM: dts: at91: sama5d27_som1_ek: set USER button as a wakeup source Claudiu Beznea
2017-10-09 16:09 ` [PATCH 05/15] ARM: dts: at91: sama5d27_som1_ek: add aliases for i2c Claudiu Beznea
2017-10-09 16:09 ` [PATCH 06/15] ARM: dts: at91: sama5d27_som1_ek: add pinmuxing for pwm0 Claudiu Beznea
2017-10-09 16:09 ` [PATCH 07/15] ARM: dts: at91: sama5d27_som1_ek: remove not connected CAN0 Claudiu Beznea
2017-10-09 16:09 ` [PATCH 08/15] ARM: dts: at91: sama5d27_som1_ek: remove pull-up on SD/MMC lines Claudiu Beznea
2017-10-09 16:09 ` [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic Claudiu Beznea
2017-10-10 0:39 ` Yang, Wenyou
2017-10-10 10:09 ` m18063 [this message]
2017-10-09 16:09 ` [PATCH 10/15] ARM: dts: at91: sama5d2_xplained: set PB_USER as wakeup source Claudiu Beznea
2017-10-09 16:09 ` [PATCH 11/15] ARM: dts: at91: sama5d2_xplained: add pinmuxing for pwm0 Claudiu Beznea
2017-10-09 16:09 ` [PATCH 12/15] ARM: dts: at91: sama5d2_xplained: remove pull-up on SD/MMC lines Claudiu Beznea
2017-10-09 16:09 ` [PATCH 13/15] ARM: dts: at91: at91sam9x25ek: add CAN1 interface Claudiu Beznea
2017-10-09 16:09 ` [PATCH 14/15] ARM: dts: at91: at91sam9x25ek: add pwm0 Claudiu Beznea
2017-10-09 16:09 ` [PATCH 15/15] ARM: dts: at91: at91sam9x5ek: use DMA for USART0 Claudiu Beznea
2017-10-10 9:30 ` [PATCH 00/14] at91 fixes and enhancements m18063
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5714eb53-d777-130e-b8bd-f80eda7c96b0@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Wenyou.Yang@Microchip.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@Microchip.com \
--cc=robh+dt@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®