From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards
Date: Tue, 19 Apr 2016 16:13:00 -0400 [thread overview]
Message-ID: <5716914C.1030102@osg.samsung.com> (raw)
In-Reply-To: <5715C629.1030602@samsung.com>
Hello Krzysztof,
On 04/19/2016 01:46 AM, Krzysztof Kozlowski wrote:
> On 04/18/2016 06:52 PM, Javier Martinez Canillas wrote:
[snip]
>>
>> On a related note, the s5m8767 regulator driver parses similar DT properties
>> ("s5m8767,pmic-buck-ramp-delay", "s5m8767,pmic-buck2-ramp-enable", etc) that
>> are not in Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt.
>>
>> So those should either be added to the binding doc or removed from the driver
>> if are not correct (I don't have documentation for the s5m8767 PMIC but the
>> DT properties are not use by any DTS in mainline using the s5m8767 PMIC).
>
> That's the grey area. :) I mean that instead of making these implemented
> bindings an interface, they should rather be converted to standard
> regulator bindings. However the device is quite old, not used on newer
> boards, so there is no interest in improving this. In the same time
> removal of this code is not strictly necessary. Its existence does not hurt.
>
Fair enough.
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
prev parent reply other threads:[~2016-04-19 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 7:44 Krzysztof Kozlowski
2016-04-18 16:52 ` Javier Martinez Canillas
2016-04-19 5:46 ` Krzysztof Kozlowski
2016-04-19 20:13 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5716914C.1030102@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome