From: Guenter Roeck <linux@roeck-us.net>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@ml01.01.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure
Date: Fri, 6 May 2016 19:22:58 -0700 [thread overview]
Message-ID: <572D5182.9090808@roeck-us.net> (raw)
In-Reply-To: <146255559866.32780.5399379827409805110.stgit@dwillia2-desk3.amr.corp.intel.com>
On 05/06/2016 10:26 AM, Dan Williams wrote:
> I had relied on the kbuild robot for cross build coverage, however it
> only builds alpha_defconfig. Switch from HPAGE_SIZE to PMD_SIZE, which
> is more widely defined.
>
> Fixes: 658922e57b84 ("libnvdimm, pfn: fix memmap reservation sizing")
> Cc: <stable@vger.kernel.org>
> Reported-by: Guenter Roeck <guenter@roeck-us.net>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Passes at least all my tests.
Tested-by: Guenter Roeck <linux@roeck-us.net>
Nitpick below.
> ---
> drivers/nvdimm/pmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 5101f3ab4f29..e5a8bf032ec9 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -404,7 +404,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn)
> * vmemmap_populate_hugepages() allocates the memmap array in
> * HPAGE_SIZE chunks.
PMD_SIZE
> */
> - memmap_size = ALIGN(64 * npfns, HPAGE_SIZE);
> + memmap_size = ALIGN(64 * npfns, PMD_SIZE);
> offset = ALIGN(start + SZ_8K + memmap_size, nd_pfn->align)
> - start;
> } else if (nd_pfn->mode == PFN_MODE_RAM)
>
>
prev parent reply other threads:[~2016-05-07 2:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 17:26 Dan Williams
2016-05-07 2:22 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572D5182.9090808@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®