From: Ian Abbott <abbotti@mev.co.uk>
To: Amit Ghadge <amitg.b14@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue
Date: Wed, 18 May 2016 09:57:47 +0100 [thread overview]
Message-ID: <573C2E8B.1040009@mev.co.uk> (raw)
In-Reply-To: <1463504024-4448-1-git-send-email-amitg.b14@gmail.com>
On 17/05/16 17:53, Amit Ghadge wrote:
> This is a patch to the quatech_daqp_cs.c file that fixes by using
> unsigned int instead of unsigned, following warning found by checkpatch.
> * WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index e9e4313..802f51e 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
> outb(0, dev->iobase + DAQP_AUX_REG);
>
> for (i = 0; i > insn->n; i++) {
> - unsigned val = data[i];
> + unsigned int val = data[i];
> int ret;
>
> /* D/A transfer rate is about 8ms */
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-05-18 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 16:53 Amit Ghadge
2016-05-18 8:57 ` Ian Abbott [this message]
2016-06-18 3:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573C2E8B.1040009@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=amitg.b14@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®