mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Anup Patel <anup.patel@broadcom.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails
Date: Mon, 23 May 2016 10:58:51 +0530	[thread overview]
Message-ID: <57429513.8040701@ti.com> (raw)
In-Reply-To: <1463980885.4421.1.camel@ingics.com>

Hi,

On Monday 23 May 2016 10:51 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

however obvious the patch maybe, it's nice to add a little commit log.

Thanks
Kishon
> ---
>  drivers/phy/phy-brcm-sata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
> index 6c4c5cb..5d7fad4b 100644
> --- a/drivers/phy/phy-brcm-sata.c
> +++ b/drivers/phy/phy-brcm-sata.c
> @@ -288,7 +288,7 @@ static int brcm_sata_phy_init(struct phy *phy)
>  		rc = -ENODEV;
>  	};
>  
> -	return 0;
> +	return rc;
>  }
>  
>  static const struct phy_ops phy_ops = {
> 

  reply	other threads:[~2016-05-23  5:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23  5:21 Axel Lin
2016-05-23  5:28 ` Kishon Vijay Abraham I [this message]
2016-05-23  5:30   ` Axel Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57429513.8040701@ti.com \
    --to=kishon@ti.com \
    --cc=anup.patel@broadcom.com \
    --cc=axel.lin@ingics.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®