From: Arnd Bergmann <arnd@arndb.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Hurley <peter@hurleysoftware.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: nozomi: avoid sprintf buffer overflow
Date: Tue, 29 Nov 2016 10:10:34 +0100 [thread overview]
Message-ID: <5750086.0s0vVYgDjM@wuerfel> (raw)
In-Reply-To: <3666ac4d-4269-5759-5d0d-1953b16a82b0@suse.cz>
On Tuesday, November 29, 2016 8:14:32 AM CET Jiri Slaby wrote:
>
> Could you also kill the now unused _err_flag_ parameter (including the
> only user of NFO)?
Right. I was trying to avoid taking the cleanup too far, lacking
a way to properly test it, but that would have been an obvious change.
> (Or inline pr_debug directly into the only user and kill NFO completely?)
I'll send both variants and let you pick one or the other.
Arnd
prev parent reply other threads:[~2016-11-29 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 21:04 Arnd Bergmann
2016-11-29 7:14 ` Jiri Slaby
2016-11-29 9:10 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5750086.0s0vVYgDjM@wuerfel \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®