From: Marc Zyngier <marc.zyngier@arm.com>
To: Zhao Qiang <qiang.zhao@nxp.com>,
tglx@linutronix.de, jason@lakedaemon.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch v12 1/4] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
Date: Tue, 7 Nov 2017 10:58:37 +0000 [thread overview]
Message-ID: <5755591c-7632-f3c8-3dc5-2bb842829f13@arm.com> (raw)
In-Reply-To: <20171106053653.23961-2-qiang.zhao@nxp.com>
On 06/11/17 05:36, Zhao Qiang wrote:
> move the driver from drivers/soc/fsl/qe to drivers/irqchip,
> merge qe_ic.h and qe_ic.c into irq-qeic.c.
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> MAINTAINERS | 6 ++
> drivers/irqchip/Makefile | 1 +
> drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 95 ++++++++++++++++++-
> drivers/soc/fsl/qe/Makefile | 2 +-
> drivers/soc/fsl/qe/qe_ic.h | 103 ---------------------
> 5 files changed, 100 insertions(+), 107 deletions(-)
> rename drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} (85%)
> delete mode 100644 drivers/soc/fsl/qe/qe_ic.h
In my previous review of the same patch, I asked for the single-bit
constants to be rewritten as BIT(x). You've done none of that. Why?
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2017-11-07 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 5:36 [Patch v12 0/4] This patchset is to remove PPCisms for QEIC Zhao Qiang
2017-11-06 5:36 ` [Patch v12 1/4] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe Zhao Qiang
2017-11-07 10:58 ` Marc Zyngier [this message]
2017-11-06 5:36 ` [Patch v12 2/4] irqchip/qeic: merge qeic init code from platforms to a common function Zhao Qiang
2017-11-06 5:36 ` [Patch v12 3/4] irqchip/qeic: merge qeic_of_init into qe_ic_init Zhao Qiang
2017-11-06 5:36 ` [Patch v12 4/4] irqchip/qeic: remove PPCisms for QEIC Zhao Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5755591c-7632-f3c8-3dc5-2bb842829f13@arm.com \
--to=marc.zyngier@arm.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=qiang.zhao@nxp.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®