From: "Jan Beulich" <JBeulich@suse.com>
To: "Boris Ostrovsky" <boris.ostrovsky@oracle.com>
Cc: "David Vrabel" <david.vrabel@citrix.com>,
"xen-devel" <xen-devel@lists.xenproject.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Juergen Gross" <JGross@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/2] xen-pciback: drop rom_init()
Date: Mon, 06 Jun 2016 07:54:37 -0600 [thread overview]
Message-ID: <57559CBD02000078000F20EC@prv-mh.provo.novell.com> (raw)
In-Reply-To: <5755761D.4020204@oracle.com>
>>> On 06.06.16 at 15:09, <boris.ostrovsky@oracle.com> wrote:
> On 06/06/2016 04:47 AM, Jan Beulich wrote:
>> It's identical to bar_init() now.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> I'm sorry for this 3/2 - I only now noticed that this additional
>> simplification is now possible.
>
> I wonder whether we should also move content of read_dev_bar() into
> bar_init(). Especially given that it's not really reading a BAR but
> rather initializing the stashed value.
I had considered that too, but then thought the splitting out of
that logic could as well stay. If we were to do that, I'd in fact
prefer merging patches 2 and 3 (plus this additional adjustment).
Jan
next prev parent reply other threads:[~2016-06-06 13:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 8:08 [PATCH 0/2] xen-pciback: correct and clean up BAR handling Jan Beulich
2016-06-06 8:11 ` [PATCH 1/2] xen-pciback: return proper values during BAR sizing Jan Beulich
2016-06-06 13:03 ` Boris Ostrovsky
2016-06-06 13:51 ` Jan Beulich
2016-06-06 14:28 ` Boris Ostrovsky
2016-06-06 8:12 ` [PATCH 2/2] xen-pciback: clean up read_dev_bar() Jan Beulich
2016-06-06 13:04 ` Boris Ostrovsky
2016-06-06 8:47 ` [PATCH 3/2] xen-pciback: drop rom_init() Jan Beulich
2016-06-06 13:09 ` Boris Ostrovsky
2016-06-06 13:54 ` Jan Beulich [this message]
2016-06-06 14:35 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57559CBD02000078000F20EC@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®