mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays
@ 2025-05-06  4:52 Rishikesh Donadkar
  2025-05-06  4:52 ` [PATCH 1/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for OV5640 Rishikesh Donadkar
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Rishikesh Donadkar @ 2025-05-06  4:52 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, devarsht,
	y-abhilashchandra, s-jain1, jai.luthra, jai.luthra,
	linux-arm-kernel, devicetree, linux-kernel, r-donadkar

Fix the follwoing dtbs_check warnings:
https://gist.github.com/Rishikesh-D/2f6e0a11f2f72ce70f75058d0caedc9f

Test Logs:
beagleplay + tevi-ov5640: https://gist.github.com/Rishikesh-D/38ac71408f108147f4de596f260ad7c3
beagleplay + ov5640: https://gist.github.com/Rishikesh-D/7911f4efdc935c22a2c97ff502c73189

Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>

Rishikesh Donadkar (2):
  arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for
    OV5640
  arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for
    TEVI-OV5640

 .../ti/k3-am625-beagleplay-csi2-ov5640.dtso   | 31 +++++++++++++++++++
 .../k3-am625-beagleplay-csi2-tevi-ov5640.dtso | 31 +++++++++++++++++++
 2 files changed, 62 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for OV5640
  2025-05-06  4:52 [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays Rishikesh Donadkar
@ 2025-05-06  4:52 ` Rishikesh Donadkar
  2025-05-06 10:02   ` Devarsh Thakkar
  2025-05-06  4:52 ` [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for TEVI-OV5640 Rishikesh Donadkar
  2025-05-06 13:09 ` [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays Nishanth Menon
  2 siblings, 1 reply; 6+ messages in thread
From: Rishikesh Donadkar @ 2025-05-06  4:52 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, devarsht,
	y-abhilashchandra, s-jain1, jai.luthra, jai.luthra,
	linux-arm-kernel, devicetree, linux-kernel, r-donadkar

The device tree overlay for OV5640 requires following voltage
supplies:

AVDD-supply: Analog voltage supply, 2.8 volts
DOVDD-supply: Digital I/O voltage supply, 1.8 volts
DVDD-supply: Digital core voltage supply, 1.5 volts

Add them in the overlay.

Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>
---
 .../ti/k3-am625-beagleplay-csi2-ov5640.dtso   | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-ov5640.dtso
index 3b4643b7d19c9..000305c9e3662 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-ov5640.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-ov5640.dtso
@@ -15,6 +15,33 @@ clk_ov5640_fixed: ov5640-xclk {
 		#clock-cells = <0>;
 		clock-frequency = <12000000>;
 	};
+
+	reg_2p8v: regulator-2p8v {
+		compatible = "regulator-fixed";
+		regulator-name = "2P8V";
+		regulator-min-microvolt = <2800000>;
+		regulator-max-microvolt = <2800000>;
+		vin-supply = <&vdd_3v3>;
+		regulator-always-on;
+	};
+
+	reg_1p8v: regulator-1p8v {
+		compatible = "regulator-fixed";
+		regulator-name = "1P8V";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		vin-supply = <&vdd_3v3>;
+		regulator-always-on;
+	};
+
+	reg_1p5v: regulator-1p5v {
+		compatible = "regulator-fixed";
+		regulator-name = "1P5V";
+		regulator-min-microvolt = <1500000>;
+		regulator-max-microvolt = <1500000>;
+		vin-supply = <&vdd_3v3>;
+		regulator-always-on;
+	};
 };
 
 &main_gpio0 {
@@ -39,6 +66,10 @@ ov5640: camera@3c {
 		clocks = <&clk_ov5640_fixed>;
 		clock-names = "xclk";
 
+		AVDD-supply = <&reg_2p8v>;
+		DOVDD-supply = <&reg_1p8v>;
+		DVDD-supply = <&reg_1p5v>;
+
 		port {
 			csi2_cam0: endpoint {
 				remote-endpoint = <&csi2rx0_in_sensor>;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for TEVI-OV5640
  2025-05-06  4:52 [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays Rishikesh Donadkar
  2025-05-06  4:52 ` [PATCH 1/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for OV5640 Rishikesh Donadkar
@ 2025-05-06  4:52 ` Rishikesh Donadkar
  2025-05-06 10:03   ` Devarsh Thakkar
  2025-05-06 13:09 ` [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays Nishanth Menon
  2 siblings, 1 reply; 6+ messages in thread
From: Rishikesh Donadkar @ 2025-05-06  4:52 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, devarsht,
	y-abhilashchandra, s-jain1, jai.luthra, jai.luthra,
	linux-arm-kernel, devicetree, linux-kernel, r-donadkar

The device tree overlay for TEVI-OV5640 requires following voltage
supplies:

AVDD-supply: Analog voltage supply, 2.8 volts
DOVDD-supply: Digital I/O voltage supply, 1.8 volts
DVDD-supply: Digital core voltage supply, 3.3 volts

Add them in the overlay.

Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>
---
 .../k3-am625-beagleplay-csi2-tevi-ov5640.dtso | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-tevi-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-tevi-ov5640.dtso
index 81a2763d43c65..8a7a9ece08af6 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-tevi-ov5640.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-tevi-ov5640.dtso
@@ -15,6 +15,33 @@ clk_ov5640_fixed: ov5640-xclk {
 		#clock-cells = <0>;
 		clock-frequency = <24000000>;
 	};
+
+	reg_2p8v: regulator-2p8v {
+		compatible = "regulator-fixed";
+		regulator-name = "2P8V";
+		regulator-min-microvolt = <2800000>;
+		regulator-max-microvolt = <2800000>;
+		vin-supply = <&vdd_3v3>;
+		regulator-always-on;
+	};
+
+	reg_1p8v: regulator-1p8v {
+		compatible = "regulator-fixed";
+		regulator-name = "1P8V";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		vin-supply = <&vdd_3v3>;
+		regulator-always-on;
+	};
+
+	reg_3p3v: regulator-3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "3P3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vdd_3v3>;
+		regulator-always-on;
+	};
 };
 
 &main_gpio0 {
@@ -39,6 +66,10 @@ ov5640: camera@3c {
 		clocks = <&clk_ov5640_fixed>;
 		clock-names = "xclk";
 
+		AVDD-supply = <&reg_2p8v>;
+		DOVDD-supply = <&reg_1p8v>;
+		DVDD-supply = <&reg_3p3v>;
+
 		port {
 			csi2_cam0: endpoint {
 				remote-endpoint = <&csi2rx0_in_sensor>;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for OV5640
  2025-05-06  4:52 ` [PATCH 1/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for OV5640 Rishikesh Donadkar
@ 2025-05-06 10:02   ` Devarsh Thakkar
  0 siblings, 0 replies; 6+ messages in thread
From: Devarsh Thakkar @ 2025-05-06 10:02 UTC (permalink / raw)
  To: Rishikesh Donadkar, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, y-abhilashchandra,
	s-jain1, jai.luthra, jai.luthra, linux-arm-kernel, devicetree,
	linux-kernel

On 06/05/25 10:22, Rishikesh Donadkar wrote:
> The device tree overlay for OV5640 requires following voltage
> supplies:
> 
> AVDD-supply: Analog voltage supply, 2.8 volts
> DOVDD-supply: Digital I/O voltage supply, 1.8 volts
> DVDD-supply: Digital core voltage supply, 1.5 volts
> 
> Add them in the overlay.
> 
> Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>

Reviewed-by: Devarsh Thakkar <devarsht@ti.com>

Regards
Devarsh
> ---
>  .../ti/k3-am625-beagleplay-csi2-ov5640.dtso   | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-ov5640.dtso
> index 3b4643b7d19c9..000305c9e3662 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-ov5640.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-ov5640.dtso
> @@ -15,6 +15,33 @@ clk_ov5640_fixed: ov5640-xclk {
>  		#clock-cells = <0>;
>  		clock-frequency = <12000000>;
>  	};
> +
> +	reg_2p8v: regulator-2p8v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "2P8V";
> +		regulator-min-microvolt = <2800000>;
> +		regulator-max-microvolt = <2800000>;
> +		vin-supply = <&vdd_3v3>;
> +		regulator-always-on;
> +	};
> +
> +	reg_1p8v: regulator-1p8v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "1P8V";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		vin-supply = <&vdd_3v3>;
> +		regulator-always-on;
> +	};
> +
> +	reg_1p5v: regulator-1p5v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "1P5V";
> +		regulator-min-microvolt = <1500000>;
> +		regulator-max-microvolt = <1500000>;
> +		vin-supply = <&vdd_3v3>;
> +		regulator-always-on;
> +	};
>  };
>  
>  &main_gpio0 {
> @@ -39,6 +66,10 @@ ov5640: camera@3c {
>  		clocks = <&clk_ov5640_fixed>;
>  		clock-names = "xclk";
>  
> +		AVDD-supply = <&reg_2p8v>;
> +		DOVDD-supply = <&reg_1p8v>;
> +		DVDD-supply = <&reg_1p5v>;
> +
>  		port {
>  			csi2_cam0: endpoint {
>  				remote-endpoint = <&csi2rx0_in_sensor>;


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for TEVI-OV5640
  2025-05-06  4:52 ` [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for TEVI-OV5640 Rishikesh Donadkar
@ 2025-05-06 10:03   ` Devarsh Thakkar
  0 siblings, 0 replies; 6+ messages in thread
From: Devarsh Thakkar @ 2025-05-06 10:03 UTC (permalink / raw)
  To: Rishikesh Donadkar, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, y-abhilashchandra,
	s-jain1, jai.luthra, jai.luthra, linux-arm-kernel, devicetree,
	linux-kernel

On 06/05/25 10:22, Rishikesh Donadkar wrote:
> The device tree overlay for TEVI-OV5640 requires following voltage
> supplies:
> 
> AVDD-supply: Analog voltage supply, 2.8 volts
> DOVDD-supply: Digital I/O voltage supply, 1.8 volts
> DVDD-supply: Digital core voltage supply, 3.3 volts
> 
> Add them in the overlay.
> 
> Signed-off-by: Rishikesh Donadkar <r-donadkar@ti.com>

Reviewed-by: Devarsh Thakkar <devarsht@ti.com>

Regards
Devarsh
> ---
>  .../k3-am625-beagleplay-csi2-tevi-ov5640.dtso | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-tevi-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-tevi-ov5640.dtso
> index 81a2763d43c65..8a7a9ece08af6 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-tevi-ov5640.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay-csi2-tevi-ov5640.dtso
> @@ -15,6 +15,33 @@ clk_ov5640_fixed: ov5640-xclk {
>  		#clock-cells = <0>;
>  		clock-frequency = <24000000>;
>  	};
> +
> +	reg_2p8v: regulator-2p8v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "2P8V";
> +		regulator-min-microvolt = <2800000>;
> +		regulator-max-microvolt = <2800000>;
> +		vin-supply = <&vdd_3v3>;
> +		regulator-always-on;
> +	};
> +
> +	reg_1p8v: regulator-1p8v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "1P8V";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		vin-supply = <&vdd_3v3>;
> +		regulator-always-on;
> +	};
> +
> +	reg_3p3v: regulator-3p3v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "3P3V";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vdd_3v3>;
> +		regulator-always-on;
> +	};
>  };
>  
>  &main_gpio0 {
> @@ -39,6 +66,10 @@ ov5640: camera@3c {
>  		clocks = <&clk_ov5640_fixed>;
>  		clock-names = "xclk";
>  
> +		AVDD-supply = <&reg_2p8v>;
> +		DOVDD-supply = <&reg_1p8v>;
> +		DVDD-supply = <&reg_3p3v>;
> +
>  		port {
>  			csi2_cam0: endpoint {
>  				remote-endpoint = <&csi2rx0_in_sensor>;


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays
  2025-05-06  4:52 [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays Rishikesh Donadkar
  2025-05-06  4:52 ` [PATCH 1/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for OV5640 Rishikesh Donadkar
  2025-05-06  4:52 ` [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for TEVI-OV5640 Rishikesh Donadkar
@ 2025-05-06 13:09 ` Nishanth Menon
  2 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2025-05-06 13:09 UTC (permalink / raw)
  To: vigneshr, Rishikesh Donadkar
  Cc: Nishanth Menon, kristo, robh, krzk+dt, conor+dt, vaishnav.a,
	devarsht, y-abhilashchandra, s-jain1, jai.luthra, jai.luthra,
	linux-arm-kernel, devicetree, linux-kernel

Hi Rishikesh Donadkar,

On Tue, 06 May 2025 10:22:23 +0530, Rishikesh Donadkar wrote:
> Fix the follwoing dtbs_check warnings:
> https://gist.github.com/Rishikesh-D/2f6e0a11f2f72ce70f75058d0caedc9f
> 
> Test Logs:
> beagleplay + tevi-ov5640: https://gist.github.com/Rishikesh-D/38ac71408f108147f4de596f260ad7c3
> beagleplay + ov5640: https://gist.github.com/Rishikesh-D/7911f4efdc935c22a2c97ff502c73189
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for OV5640
      commit: a5da12f37b8532b7ea9196ae7c7927a535883194
[2/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for TEVI-OV5640
      commit: cabe662bd54b37deb7ebf0a4dbaabc7812fa411c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-06 13:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-06  4:52 [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays Rishikesh Donadkar
2025-05-06  4:52 ` [PATCH 1/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for OV5640 Rishikesh Donadkar
2025-05-06 10:02   ` Devarsh Thakkar
2025-05-06  4:52 ` [PATCH 2/2] arm64: dts: ti: k3-am625-beagleplay: Add required voltage supplies for TEVI-OV5640 Rishikesh Donadkar
2025-05-06 10:03   ` Devarsh Thakkar
2025-05-06 13:09 ` [PATCH 0/2] Fix dtbs_check warnings in ov5640 sensor overlays Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®