* [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate
@ 2026-08-21 4:52 Sivansh Gupta
2026-08-21 5:08 ` Abel Vesa
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sivansh Gupta @ 2026-08-21 4:52 UTC (permalink / raw)
To: andersson; +Cc: linux-arm-msm, linux-clk, linux-kernel, Sivansh Gupta
Commit 6b150572bb76 ("clk: qcom: Add defaults for desired arm64 drivers")
missed adding a defaults for CLK_GLYMUR_GPUCC and created a duplicated
for CLK_GLYMUR_EVACC instead. The original patch series did't have this
problem and was introduced during the merge. Fix this by removing the
duplicate and adding a default for CLK_GLYMUR_GPUCC.
Fixes: 6b150572bb76 ("clk: qcom: Add defaults for desired arm64 drivers")
Signed-off-by: Sivansh Gupta <sivansh.gupta@oss.qualcomm.com>
---
drivers/clk/qcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index e609a7819e07..7cd3ab277d37 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -104,7 +104,6 @@ config CLK_GLYMUR_DISPCC
config CLK_GLYMUR_EVACC
tristate "Glymur EVA Clock Controller"
depends on ARM64 || COMPILE_TEST
- default m if ARCH_QCOM
select CLK_GLYMUR_GCC
default m if ARCH_QCOM
help
@@ -127,6 +126,7 @@ config CLK_GLYMUR_GPUCC
tristate "Glymur Graphics Clock Controller"
depends on ARM64 || COMPILE_TEST
select CLK_GLYMUR_GCC
+ default m if ARCH_QCOM
help
Support for the graphics clock controller on Glymur devices.
Say Y if you want to support graphics controller devices and
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate
2026-08-21 4:52 [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate Sivansh Gupta
@ 2026-08-21 5:08 ` Abel Vesa
2026-08-21 6:11 ` Pankaj Patil
2026-09-16 22:31 ` [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Abel Vesa @ 2026-08-21 5:08 UTC (permalink / raw)
To: Sivansh Gupta; +Cc: andersson, linux-arm-msm, linux-clk, linux-kernel
On 26-08-21 10:22:15, Sivansh Gupta wrote:
> Commit 6b150572bb76 ("clk: qcom: Add defaults for desired arm64 drivers")
> missed adding a defaults for CLK_GLYMUR_GPUCC and created a duplicated
> for CLK_GLYMUR_EVACC instead. The original patch series did't have this
> problem and was introduced during the merge. Fix this by removing the
> duplicate and adding a default for CLK_GLYMUR_GPUCC.
>
> Fixes: 6b150572bb76 ("clk: qcom: Add defaults for desired arm64 drivers")
>
Drop this blank line here.
> Signed-off-by: Sivansh Gupta <sivansh.gupta@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> drivers/clk/qcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e609a7819e07..7cd3ab277d37 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -104,7 +104,6 @@ config CLK_GLYMUR_DISPCC
> config CLK_GLYMUR_EVACC
> tristate "Glymur EVA Clock Controller"
> depends on ARM64 || COMPILE_TEST
> - default m if ARCH_QCOM
> select CLK_GLYMUR_GCC
> default m if ARCH_QCOM
> help
> @@ -127,6 +126,7 @@ config CLK_GLYMUR_GPUCC
> tristate "Glymur Graphics Clock Controller"
> depends on ARM64 || COMPILE_TEST
> select CLK_GLYMUR_GCC
> + default m if ARCH_QCOM
> help
> Support for the graphics clock controller on Glymur devices.
> Say Y if you want to support graphics controller devices and
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate
2026-08-21 4:52 [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate Sivansh Gupta
2026-08-21 5:08 ` Abel Vesa
@ 2026-08-21 6:11 ` Pankaj Patil
2026-09-08 14:56 ` [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default Sivansh Gupta
2026-09-16 22:31 ` [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Pankaj Patil @ 2026-08-21 6:11 UTC (permalink / raw)
To: Sivansh Gupta, andersson; +Cc: linux-arm-msm, linux-clk, linux-kernel
On 8/21/2026 10:22 AM, Sivansh Gupta wrote:
> Commit 6b150572bb76 ("clk: qcom: Add defaults for desired arm64 drivers")
> missed adding a defaults for CLK_GLYMUR_GPUCC and created a duplicated
> for CLK_GLYMUR_EVACC instead. The original patch series did't have this
> problem and was introduced during the merge. Fix this by removing the
> duplicate and adding a default for CLK_GLYMUR_GPUCC.
>
> Fixes: 6b150572bb76 ("clk: qcom: Add defaults for desired arm64 drivers")
>
> Signed-off-by: Sivansh Gupta <sivansh.gupta@oss.qualcomm.com>
Reviewed-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
> drivers/clk/qcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e609a7819e07..7cd3ab277d37 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -104,7 +104,6 @@ config CLK_GLYMUR_DISPCC
> config CLK_GLYMUR_EVACC
> tristate "Glymur EVA Clock Controller"
> depends on ARM64 || COMPILE_TEST
> - default m if ARCH_QCOM
> select CLK_GLYMUR_GCC
> default m if ARCH_QCOM
> help
> @@ -127,6 +126,7 @@ config CLK_GLYMUR_GPUCC
> tristate "Glymur Graphics Clock Controller"
> depends on ARM64 || COMPILE_TEST
> select CLK_GLYMUR_GCC
> + default m if ARCH_QCOM
> help
> Support for the graphics clock controller on Glymur devices.
> Say Y if you want to support graphics controller devices and
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default
2026-08-21 6:11 ` Pankaj Patil
@ 2026-09-08 14:56 ` Sivansh Gupta
2026-09-09 9:20 ` Konrad Dybcio
0 siblings, 1 reply; 6+ messages in thread
From: Sivansh Gupta @ 2026-09-08 14:56 UTC (permalink / raw)
To: andersson
Cc: pankaj.patil, linux-arm-msm, linux-clk, linux-kernel, sivansh.gupta
Hey, this patch has not received an ack, please let me know if
anything is needed from my side.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default
2026-09-08 14:56 ` [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default Sivansh Gupta
@ 2026-09-09 9:20 ` Konrad Dybcio
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2026-09-09 9:20 UTC (permalink / raw)
To: Sivansh Gupta, andersson
Cc: pankaj.patil, linux-arm-msm, linux-clk, linux-kernel
On 9/8/26 4:56 PM, Sivansh Gupta wrote:
> Hey, this patch has not received an ack, please let me know if
> anything is needed from my side.
You already received two, which is more than plenty for a
trivial 2-liner!
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate
2026-08-21 4:52 [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate Sivansh Gupta
2026-08-21 5:08 ` Abel Vesa
2026-08-21 6:11 ` Pankaj Patil
@ 2026-09-16 22:31 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2026-09-16 22:31 UTC (permalink / raw)
To: Sivansh Gupta; +Cc: linux-arm-msm, linux-clk, linux-kernel
On Fri, 21 Aug 2026 10:22:15 +0530, Sivansh Gupta wrote:
> Commit 6b150572bb76 ("clk: qcom: Add defaults for desired arm64 drivers")
> missed adding a defaults for CLK_GLYMUR_GPUCC and created a duplicated
> for CLK_GLYMUR_EVACC instead. The original patch series did't have this
> problem and was introduced during the merge. Fix this by removing the
> duplicate and adding a default for CLK_GLYMUR_GPUCC.
>
> Fixes: 6b150572bb76 ("clk: qcom: Add defaults for desired arm64 drivers")
>
> [...]
Applied, thanks!
[1/1] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate
commit: 364709a9d450ae3814726768aec6611e5f003467
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-16 22:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-21 4:52 [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate Sivansh Gupta
2026-08-21 5:08 ` Abel Vesa
2026-08-21 6:11 ` Pankaj Patil
2026-09-08 14:56 ` [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default Sivansh Gupta
2026-09-09 9:20 ` Konrad Dybcio
2026-09-16 22:31 ` [PATCH] clk: qcom: Fix CLK_GLYMUR_GPUCC default and CLK_GLYMUR_EVACC duplicate Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®