From: "Jan Beulich" <JBeulich@suse.com>
To: "David Vrabel" <david.vrabel@citrix.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <JGross@suse.com>
Cc: "xen-devel" <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v4 6/7] xen-pciback: short-circuit read path used for merging write values
Date: Wed, 06 Jul 2016 00:59:35 -0600 [thread overview]
Message-ID: <577CC87702000078000FB800@prv-mh.provo.novell.com> (raw)
In-Reply-To: <577CC59602000078000FB7A0@prv-mh.provo.novell.com>
There's no point calling xen_pcibk_config_read() here - all it'll do is
return whatever conf_space_read() returns for the field which was found
here (and which would be found there again). Also there's no point
clearing tmp_val before the call.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/xen/xen-pciback/conf_space.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- 4.7-rc6-xen-pciback.orig/drivers/xen/xen-pciback/conf_space.c
+++ 4.7-rc6-xen-pciback/drivers/xen/xen-pciback/conf_space.c
@@ -230,10 +230,8 @@ int xen_pcibk_config_write(struct pci_de
field_end = OFFSET(cfg_entry) + field->size;
if (req_end > field_start && field_end > req_start) {
- tmp_val = 0;
-
- err = xen_pcibk_config_read(dev, field_start,
- field->size, &tmp_val);
+ err = conf_space_read(dev, cfg_entry, field_start,
+ &tmp_val);
if (err)
break;
next prev parent reply other threads:[~2016-07-06 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 6:47 [PATCH v4 0/7] xen-pciback: misc cleanup Jan Beulich
2016-07-06 6:56 ` [PATCH v4 1/7] xen-pciback: drop unused function parameter of read_dev_bar() Jan Beulich
2016-07-06 6:57 ` [PATCH v4 2/7] xen-pciback: drop rom_init() Jan Beulich
2016-07-06 6:57 ` [PATCH v4 3/7] xen-pciback: fold read_dev_bar() into its now single caller Jan Beulich
2016-07-06 6:58 ` [PATCH v4 4/7] xen-pciback: simplify determination of 64-bit memory resource Jan Beulich
2016-07-06 6:58 ` [PATCH v4 5/7] xen-pciback: use const and unsigned in bar_init() Jan Beulich
2016-07-06 6:59 ` Jan Beulich [this message]
2016-07-06 7:00 ` [PATCH v4 7/7] xen-pciback: drop superfluous variables Jan Beulich
2016-07-06 9:41 ` [Xen-devel] [PATCH v4 0/7] xen-pciback: misc cleanup David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577CC87702000078000FB800@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®