* [PATCH] hwtracing: coresight: Replace acpi_bus_get_device()
@ 2022-02-01 17:58 Rafael J. Wysocki
2022-02-02 11:43 ` Suzuki K Poulose
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-02-01 17:58 UTC (permalink / raw)
To: Alexander Shishkin
Cc: Mathieu Poirier, Suzuki K Poulose, Mike Leach, Leo Yan, LKML, Linux ACPI
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Replace acpi_bus_get_device() that is going to be dropped with
acpi_fetch_acpi_dev().
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/hwtracing/coresight/coresight-platform.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
===================================================================
--- linux-pm.orig/drivers/hwtracing/coresight/coresight-platform.c
+++ linux-pm/drivers/hwtracing/coresight/coresight-platform.c
@@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
const union acpi_object *link,
struct coresight_connection *conn)
{
- int rc, dir;
+ int dir;
const union acpi_object *fields;
struct acpi_device *r_adev;
struct device *rdev;
@@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
fields[3].type != ACPI_TYPE_INTEGER)
return -EINVAL;
- rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
- if (rc)
- return rc;
+ r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
+ if (!r_adev)
+ return -ENODEV;
dir = fields[3].integer.value;
if (dir == ACPI_CORESIGHT_LINK_MASTER) {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwtracing: coresight: Replace acpi_bus_get_device()
2022-02-01 17:58 [PATCH] hwtracing: coresight: Replace acpi_bus_get_device() Rafael J. Wysocki
@ 2022-02-02 11:43 ` Suzuki K Poulose
2022-02-02 13:44 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Suzuki K Poulose @ 2022-02-02 11:43 UTC (permalink / raw)
To: Rafael J. Wysocki, Alexander Shishkin
Cc: Mathieu Poirier, Mike Leach, Leo Yan, LKML, Linux ACPI
Hi Rafael
On 01/02/2022 17:58, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Replace acpi_bus_get_device() that is going to be dropped with
> acpi_fetch_acpi_dev().
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/hwtracing/coresight/coresight-platform.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
> ===================================================================
> --- linux-pm.orig/drivers/hwtracing/coresight/coresight-platform.c
> +++ linux-pm/drivers/hwtracing/coresight/coresight-platform.c
> @@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
> const union acpi_object *link,
> struct coresight_connection *conn)
> {
> - int rc, dir;
> + int dir;
> const union acpi_object *fields;
> struct acpi_device *r_adev;
> struct device *rdev;
> @@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
> fields[3].type != ACPI_TYPE_INTEGER)
> return -EINVAL;
>
> - rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
> - if (rc)
> - return rc;
> + r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
> + if (!r_adev)
> + return -ENODEV;
>
Is this patch part of a series ? I don't see acpi_fetch_acpi_dev()
in v5.17-rc1, which our tree is based on at the moment. Please could
you point us to the changes ?
Also do you expect to pull this via your tree ?
Cheers
Suzuki
> dir = fields[3].integer.value;
> if (dir == ACPI_CORESIGHT_LINK_MASTER) {
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwtracing: coresight: Replace acpi_bus_get_device()
2022-02-02 11:43 ` Suzuki K Poulose
@ 2022-02-02 13:44 ` Rafael J. Wysocki
2022-02-02 16:46 ` Suzuki K Poulose
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-02-02 13:44 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: Rafael J. Wysocki, Alexander Shishkin, Mathieu Poirier,
Mike Leach, Leo Yan, LKML, Linux ACPI
On Wed, Feb 2, 2022 at 12:43 PM Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>
> Hi Rafael
>
> On 01/02/2022 17:58, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Replace acpi_bus_get_device() that is going to be dropped with
> > acpi_fetch_acpi_dev().
> >
> > No intentional functional impact.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
>
> > ---
> > drivers/hwtracing/coresight/coresight-platform.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
> > ===================================================================
> > --- linux-pm.orig/drivers/hwtracing/coresight/coresight-platform.c
> > +++ linux-pm/drivers/hwtracing/coresight/coresight-platform.c
> > @@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
> > const union acpi_object *link,
> > struct coresight_connection *conn)
> > {
> > - int rc, dir;
> > + int dir;
> > const union acpi_object *fields;
> > struct acpi_device *r_adev;
> > struct device *rdev;
> > @@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
> > fields[3].type != ACPI_TYPE_INTEGER)
> > return -EINVAL;
> >
> > - rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
> > - if (rc)
> > - return rc;
> > + r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
> > + if (!r_adev)
> > + return -ENODEV;
> >
>
> Is this patch part of a series ?
No, it isn't.
> I don't see acpi_fetch_acpi_dev() in v5.17-rc1, which our tree is based on at the moment.
acpi_fetch_acpi_dev() is there in v5.17-rc1. Please see
https://elixir.bootlin.com/linux/v5.17-rc1/A/ident/acpi_fetch_acpi_dev
> Please could you point us to the changes ?
>
> Also do you expect to pull this via your tree ?
I can route it via the ACPI tree, but it may as well be routed along
with other coresight-platform.c changes, if any.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwtracing: coresight: Replace acpi_bus_get_device()
2022-02-02 13:44 ` Rafael J. Wysocki
@ 2022-02-02 16:46 ` Suzuki K Poulose
2022-02-02 16:48 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Suzuki K Poulose @ 2022-02-02 16:46 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rafael J. Wysocki, Alexander Shishkin, Mathieu Poirier,
Mike Leach, Leo Yan, LKML, Linux ACPI
On 02/02/2022 13:44, Rafael J. Wysocki wrote:
> On Wed, Feb 2, 2022 at 12:43 PM Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>>
>> Hi Rafael
>>
>> On 01/02/2022 17:58, Rafael J. Wysocki wrote:
>>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>
>>> Replace acpi_bus_get_device() that is going to be dropped with
>>> acpi_fetch_acpi_dev().
>>>
>>> No intentional functional impact.
>>>
>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>>
>>> ---
>>> drivers/hwtracing/coresight/coresight-platform.c | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
>>> ===================================================================
>>> --- linux-pm.orig/drivers/hwtracing/coresight/coresight-platform.c
>>> +++ linux-pm/drivers/hwtracing/coresight/coresight-platform.c
>>> @@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
>>> const union acpi_object *link,
>>> struct coresight_connection *conn)
>>> {
>>> - int rc, dir;
>>> + int dir;
>>> const union acpi_object *fields;
>>> struct acpi_device *r_adev;
>>> struct device *rdev;
>>> @@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
>>> fields[3].type != ACPI_TYPE_INTEGER)
>>> return -EINVAL;
>>>
>>> - rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
>>> - if (rc)
>>> - return rc;
>>> + r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
>>> + if (!r_adev)
>>> + return -ENODEV;
>>>
>>
>> Is this patch part of a series ?
>
> No, it isn't.
>
>> I don't see acpi_fetch_acpi_dev() in v5.17-rc1, which our tree is based on at the moment.
>
> acpi_fetch_acpi_dev() is there in v5.17-rc1. Please see
>
> https://elixir.bootlin.com/linux/v5.17-rc1/A/ident/acpi_fetch_acpi_dev
>
>> Please could you point us to the changes ?
>>
>> Also do you expect to pull this via your tree ?
>
> I can route it via the ACPI tree, but it may as well be routed along
> with other coresight-platform.c changes, if any.
Apologies, obviously, I was looking at the wrong tree. I will queue this
Thanks
Suzuki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hwtracing: coresight: Replace acpi_bus_get_device()
2022-02-02 16:46 ` Suzuki K Poulose
@ 2022-02-02 16:48 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-02-02 16:48 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: Rafael J. Wysocki, Rafael J. Wysocki, Alexander Shishkin,
Mathieu Poirier, Mike Leach, Leo Yan, LKML, Linux ACPI
On Wed, Feb 2, 2022 at 5:46 PM Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>
> On 02/02/2022 13:44, Rafael J. Wysocki wrote:
> > On Wed, Feb 2, 2022 at 12:43 PM Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
> >>
> >> Hi Rafael
> >>
> >> On 01/02/2022 17:58, Rafael J. Wysocki wrote:
> >>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >>>
> >>> Replace acpi_bus_get_device() that is going to be dropped with
> >>> acpi_fetch_acpi_dev().
> >>>
> >>> No intentional functional impact.
> >>>
> >>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >>
> >>
> >>> ---
> >>> drivers/hwtracing/coresight/coresight-platform.c | 8 ++++----
> >>> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>>
> >>> Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
> >>> ===================================================================
> >>> --- linux-pm.orig/drivers/hwtracing/coresight/coresight-platform.c
> >>> +++ linux-pm/drivers/hwtracing/coresight/coresight-platform.c
> >>> @@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
> >>> const union acpi_object *link,
> >>> struct coresight_connection *conn)
> >>> {
> >>> - int rc, dir;
> >>> + int dir;
> >>> const union acpi_object *fields;
> >>> struct acpi_device *r_adev;
> >>> struct device *rdev;
> >>> @@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
> >>> fields[3].type != ACPI_TYPE_INTEGER)
> >>> return -EINVAL;
> >>>
> >>> - rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
> >>> - if (rc)
> >>> - return rc;
> >>> + r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
> >>> + if (!r_adev)
> >>> + return -ENODEV;
> >>>
> >>
> >> Is this patch part of a series ?
> >
> > No, it isn't.
> >
> >> I don't see acpi_fetch_acpi_dev() in v5.17-rc1, which our tree is based on at the moment.
> >
> > acpi_fetch_acpi_dev() is there in v5.17-rc1. Please see
> >
> > https://elixir.bootlin.com/linux/v5.17-rc1/A/ident/acpi_fetch_acpi_dev
> >
> >> Please could you point us to the changes ?
> >>
> >> Also do you expect to pull this via your tree ?
> >
> > I can route it via the ACPI tree, but it may as well be routed along
> > with other coresight-platform.c changes, if any.
>
> Apologies, obviously, I was looking at the wrong tree. I will queue this
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-02 16:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 17:58 [PATCH] hwtracing: coresight: Replace acpi_bus_get_device() Rafael J. Wysocki
2022-02-02 11:43 ` Suzuki K Poulose
2022-02-02 13:44 ` Rafael J. Wysocki
2022-02-02 16:46 ` Suzuki K Poulose
2022-02-02 16:48 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®