* [PATCH v2] checkpatch: Improve ALLOC_ARRAY_ARGS test
@ 2021-04-16 17:57 Christophe JAILLET
2021-04-16 18:04 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-04-16 17:57 UTC (permalink / raw)
To: apw, joe, dwaipayanray1, lukas.bulwahn
Cc: linux-kernel, kernel-janitors, Christophe JAILLET
The devm_ variant of 'kcalloc()' and 'kmalloc_array()' are not tested
Add the corresponding check.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
v2: use a cleaner regex as proposed by Joe Perches
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 44b9dc330ac6..23697a6b1eaa 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -7006,7 +7006,7 @@ sub process {
}
# check for alloc argument mismatch
- if ($line =~ /\b(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) {
+ if ($line =~ /\b((?:devm_)?(?:kcalloc|kmalloc_array))\s*\(\s*sizeof\b/) {
WARN("ALLOC_ARRAY_ARGS",
"$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr);
}
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] checkpatch: Improve ALLOC_ARRAY_ARGS test
2021-04-16 17:57 [PATCH v2] checkpatch: Improve ALLOC_ARRAY_ARGS test Christophe JAILLET
@ 2021-04-16 18:04 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2021-04-16 18:04 UTC (permalink / raw)
To: Christophe JAILLET, apw, dwaipayanray1, lukas.bulwahn, Andrew Morton
Cc: linux-kernel, kernel-janitors
On Fri, 2021-04-16 at 19:57 +0200, Christophe JAILLET wrote:
> The devm_ variant of 'kcalloc()' and 'kmalloc_array()' are not tested
> Add the corresponding check.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> v2: use a cleaner regex as proposed by Joe Perches
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 44b9dc330ac6..23697a6b1eaa 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -7006,7 +7006,7 @@ sub process {
> }
>
>
> # check for alloc argument mismatch
> - if ($line =~ /\b(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) {
> + if ($line =~ /\b((?:devm_)?(?:kcalloc|kmalloc_array))\s*\(\s*sizeof\b/) {
> WARN("ALLOC_ARRAY_ARGS",
> "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-16 18:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 17:57 [PATCH v2] checkpatch: Improve ALLOC_ARRAY_ARGS test Christophe JAILLET
2021-04-16 18:04 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®