mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Haoxiang Li" <lihaoxiang@isrc.iscas.ac.cn>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Felix Kühling" <felix.kuehling@amd.com>,
	"Oak Zeng" <ozeng@amd.com>, "Simona Vetter" <simona@ffwll.ch>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/amdkfd: fix a memory leak in device_queue_manager_init()
Date: Tue, 6 Jan 2026 10:30:15 +0100	[thread overview]
Message-ID: <57a9f219-2612-4a64-a9fb-44b04e09ec15@web.de> (raw)
In-Reply-To: <20260106015731.1906738-1-lihaoxiang@isrc.iscas.ac.cn>

…
> Move deallocate_hiq_sdma_mqd() up to ensure proper function
> visibility at the point of use.

…
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -2919,6 +2919,14 @@ static int allocate_hiq_sdma_mqd(struct device_queue_manager *dqm)
>  	return retval;
>  }
>  
> +static void deallocate_hiq_sdma_mqd(struct kfd_node *dev,
> +				    struct kfd_mem_obj *mqd)
> +{
> +	WARN(!mqd, "No hiq sdma mqd trunk to free");
> +
> +	amdgpu_amdkfd_free_gtt_mem(dev->adev, &mqd->gtt_mem);
> +}

Is there also a need to reconsider the implementation of the applied
null pointer check here?

Regards,
Markus

  reply	other threads:[~2026-01-06  9:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06  1:57 Haoxiang Li
2026-01-06  9:30 ` Markus Elfring [this message]
2026-01-08 23:02   ` Felix Kuehling
2026-01-09  8:37     ` [v2] " Markus Elfring
2026-01-09 21:16       ` Kuehling, Felix
2026-01-10  7:20         ` Markus Elfring
2026-01-08  2:15 ` [PATCH v2] " Zeng, Oak
2026-01-08  7:20   ` Haoxiang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57a9f219-2612-4a64-a9fb-44b04e09ec15@web.de \
    --to=markus.elfring@web.de \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felix.kuehling@amd.com \
    --cc=lihaoxiang@isrc.iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ozeng@amd.com \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®