From: "Kuehling, Felix" <felix.kuehling@amd.com>
To: "Markus Elfring" <Markus.Elfring@web.de>,
"Haoxiang Li" <lihaoxiang@isrc.iscas.ac.cn>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>, "Oak Zeng" <ozeng@amd.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v2] drm/amdkfd: fix a memory leak in device_queue_manager_init()
Date: Fri, 9 Jan 2026 16:16:47 -0500 [thread overview]
Message-ID: <dc26748a-3ef4-4b7c-9772-8dd7a7f03364@amd.com> (raw)
In-Reply-To: <e76fc27b-0742-4685-96e6-f6000bd62fa8@web.de>
On 2026-01-09 03:37, Markus Elfring wrote:
>> My conclusion is that this WARN is just unnecessary.
> Would you like to omit such a questionable macro call then?
I don't feel strongly about it. I already submitted Haoxiang's patch.
>
>
>> But it's also harmless.
> How do you think about to avoid special development concerns here?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc4#n1242
No. I think the WARN is used exactly as it was meant to be here: to
check for something that should never happen.
Regards,
Felix
>
> Regards,
> Markus
next prev parent reply other threads:[~2026-01-09 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 1:57 [PATCH v2] " Haoxiang Li
2026-01-06 9:30 ` Markus Elfring
2026-01-08 23:02 ` Felix Kuehling
2026-01-09 8:37 ` [v2] " Markus Elfring
2026-01-09 21:16 ` Kuehling, Felix [this message]
2026-01-10 7:20 ` Markus Elfring
2026-01-08 2:15 ` [PATCH v2] " Zeng, Oak
2026-01-08 7:20 ` Haoxiang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc26748a-3ef4-4b7c-9772-8dd7a7f03364@amd.com \
--to=felix.kuehling@amd.com \
--cc=Markus.Elfring@web.de \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=ozeng@amd.com \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®