[PATCH] cgroup: Use seq_putc() in three functions

[PATCH] cgroup: Use seq_putc() in three functions

[Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 14 Jul 2024 11:24:05 +0200

Single characters should be put into a sequence.
Thus use the corresponding function “seq_putc”.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 kernel/cgroup/cgroup.c | 2 +-
 kernel/cgroup/debug.c  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index c8e4b62b436a..9197f3c591a9 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -6316,7 +6316,7 @@ int proc_cgroup_show(struct seq_file *m, struct pid_namespace *ns,

 			seq_puts(m, buf);
 		} else {
-			seq_puts(m, "/");
+			seq_putc(m, '/');
 		}

 		if (cgroup_on_dfl(cgrp) && cgroup_is_dead(cgrp))
diff --git a/kernel/cgroup/debug.c b/kernel/cgroup/debug.c
index 80aa3f027ac3..d18f7dcb4def 100644
--- a/kernel/cgroup/debug.c
+++ b/kernel/cgroup/debug.c
@@ -55,7 +55,7 @@ static int current_css_set_read(struct seq_file *seq, void *v)
 	seq_printf(seq, "css_set %pK %d", cset, refcnt);
 	if (refcnt > cset->nr_tasks)
 		seq_printf(seq, " +%d", refcnt - cset->nr_tasks);
-	seq_puts(seq, "\n");
+	seq_putc(seq, '\n');

 	/*
 	 * Print the css'es stored in the current css_set.
@@ -159,7 +159,7 @@ static int cgroup_css_links_read(struct seq_file *seq, void *v)
 				extra_refs += extra;
 			}
 		}
-		seq_puts(seq, "\n");
+		seq_putc(seq, '\n');

 		list_for_each_entry(task, &cset->tasks, cg_list) {
 			if (count++ <= MAX_TASKS_SHOWN_PER_CSS)
@@ -189,7 +189,7 @@ static int cgroup_css_links_read(struct seq_file *seq, void *v)
 	if (!dead_cnt && !extra_refs && !threaded_csets)
 		return 0;

-	seq_puts(seq, "\n");
+	seq_putc(seq, '\n');
 	if (threaded_csets)
 		seq_printf(seq, "threaded css_sets = %d\n", threaded_csets);
 	if (extra_refs)
--
2.45.2

Re: [PATCH] cgroup: Use seq_putc() in three functions

[Michal Koutný]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

Hello.

On Sun, Jul 14, 2024 at 11:33:18AM GMT, Markus Elfring <Markus.Elfring@web.de> wrote:
> Single characters should be put into a sequence.
> Thus use the corresponding function “seq_putc”.

seq_puts() handles internally the single char strings already and
calling one function uniformly seems less error prone in general.  I see
only marginal benefit of the change in this context .

> This issue was transformed by using the Coccinelle software.

Maybe that would better fit under scripts/coccinelle/misc for optional
checking.

Thanks,
Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: cgroup: Use seq_putc() in three functions

[Markus Elfring]

>> This issue was transformed by using the Coccinelle software.
>
> Maybe that would better fit under scripts/coccinelle/misc for optional checking.

Would you like to support any corresponding developments also according to
the coccicheck tool?

Regards,
Markus