* [PATCH v2 0/2] drm/amd/display: Remove a unused variable and mark a function as static
@ 2023-03-29 18:05 Caio Novais
2023-03-29 18:05 ` [PATCH v2 1/2] drm/amd/display: Remove unused variable 'scl_enable' Caio Novais
2023-03-29 18:05 ` [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending_clear' as static Caio Novais
0 siblings, 2 replies; 4+ messages in thread
From: Caio Novais @ 2023-03-29 18:05 UTC (permalink / raw)
To: amd-gfx, dri-devel, linux-kernel
Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Wesley Chalmers, Lee, Alvin, Jun Lei, Qingqing Zhuo,
Aurabindo Pillai, Caio Novais, Hamza Mahfooz, Jiapeng Chong,
Nicholas Kazlauskas, Gabe Teeger, Roman Li, Maíra Canal,
Deepak R Varma
This patchset removes one unused variable and mark a function as static.
Caio Novais (2):
drm/amd/display: Remove unused variable 'scl_enable'
drm/amd/display: Mark function
'optc3_wait_drr_doublebuffer_pending_clear' as static
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +-
.../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
--
2.40.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 1/2] drm/amd/display: Remove unused variable 'scl_enable'
2023-03-29 18:05 [PATCH v2 0/2] drm/amd/display: Remove a unused variable and mark a function as static Caio Novais
@ 2023-03-29 18:05 ` Caio Novais
2023-03-29 18:05 ` [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending_clear' as static Caio Novais
1 sibling, 0 replies; 4+ messages in thread
From: Caio Novais @ 2023-03-29 18:05 UTC (permalink / raw)
To: amd-gfx, dri-devel, linux-kernel
Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Wesley Chalmers, Lee, Alvin, Jun Lei, Qingqing Zhuo,
Aurabindo Pillai, Caio Novais, Hamza Mahfooz, Jiapeng Chong,
Nicholas Kazlauskas, Gabe Teeger, Roman Li, Maíra Canal,
Deepak R Varma
Compiling AMD GPU drivers displays a warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c: In function ‘dml_rq_dlg_get_dlg_params’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:991:14: warning: variable ‘scl_enable’ set but not used [-Wunused-but-set-variable]
Get rid of it by removing the variable 'scl_enable'.
Signed-off-by: Caio Novais <caionovais@usp.br>
---
.../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
index d1c2693a2e28..ea4eb66066c4 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
@@ -988,7 +988,6 @@ static void dml_rq_dlg_get_dlg_params(
double hratio_c;
double vratio_l;
double vratio_c;
- bool scl_enable;
unsigned int swath_width_ub_l;
unsigned int dpte_groups_per_row_ub_l;
@@ -1117,7 +1116,6 @@ static void dml_rq_dlg_get_dlg_params(
hratio_c = scl->hscl_ratio_c;
vratio_l = scl->vscl_ratio;
vratio_c = scl->vscl_ratio_c;
- scl_enable = scl->scl_enable;
swath_width_ub_l = rq_dlg_param->rq_l.swath_width_ub;
dpte_groups_per_row_ub_l = rq_dlg_param->rq_l.dpte_groups_per_row_ub;
--
2.40.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending_clear' as static
2023-03-29 18:05 [PATCH v2 0/2] drm/amd/display: Remove a unused variable and mark a function as static Caio Novais
2023-03-29 18:05 ` [PATCH v2 1/2] drm/amd/display: Remove unused variable 'scl_enable' Caio Novais
@ 2023-03-29 18:05 ` Caio Novais
2023-03-29 19:00 ` Hamza Mahfooz
1 sibling, 1 reply; 4+ messages in thread
From: Caio Novais @ 2023-03-29 18:05 UTC (permalink / raw)
To: amd-gfx, dri-devel, linux-kernel
Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Wesley Chalmers, Lee, Alvin, Jun Lei, Qingqing Zhuo,
Aurabindo Pillai, Caio Novais, Hamza Mahfooz, Jiapeng Chong,
Nicholas Kazlauskas, Gabe Teeger, Roman Li, Maíra Canal,
Deepak R Varma
Compiling AMD GPU drivers displays a warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes]
Get rid of it by marking the function as static
Signed-off-by: Caio Novais <caionovais@usp.br>
---
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
index 08b92715e2e6..c95f000b63b2 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
@@ -291,7 +291,7 @@ static void optc3_set_timing_double_buffer(struct timing_generator *optc, bool e
OTG_DRR_TIMING_DBUF_UPDATE_MODE, mode);
}
-void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
+static void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
{
struct optc *optc1 = DCN10TG_FROM_TG(optc);
--
2.40.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending_clear' as static
2023-03-29 18:05 ` [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending_clear' as static Caio Novais
@ 2023-03-29 19:00 ` Hamza Mahfooz
0 siblings, 0 replies; 4+ messages in thread
From: Hamza Mahfooz @ 2023-03-29 19:00 UTC (permalink / raw)
To: Caio Novais, amd-gfx, dri-devel, linux-kernel
Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Wesley Chalmers, Lee, Alvin, Jun Lei, Qingqing Zhuo,
Aurabindo Pillai, Jiapeng Chong, Nicholas Kazlauskas,
Gabe Teeger, Roman Li, Maíra Canal, Deepak R Varma
On 3/29/23 14:05, Caio Novais wrote:
> Compiling AMD GPU drivers displays a warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes]
>
> Get rid of it by marking the function as static
>
> Signed-off-by: Caio Novais <caionovais@usp.br>
Applied, thanks!
> ---
> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> index 08b92715e2e6..c95f000b63b2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> @@ -291,7 +291,7 @@ static void optc3_set_timing_double_buffer(struct timing_generator *optc, bool e
> OTG_DRR_TIMING_DBUF_UPDATE_MODE, mode);
> }
>
> -void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
> +static void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
> {
> struct optc *optc1 = DCN10TG_FROM_TG(optc);
>
--
Hamza
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-29 18:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-29 18:05 [PATCH v2 0/2] drm/amd/display: Remove a unused variable and mark a function as static Caio Novais
2023-03-29 18:05 ` [PATCH v2 1/2] drm/amd/display: Remove unused variable 'scl_enable' Caio Novais
2023-03-29 18:05 ` [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending_clear' as static Caio Novais
2023-03-29 19:00 ` Hamza Mahfooz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®