* [PATCH] usb: gadget: aspeed: Add NULL pointer check in ast_vhub_init_dev()
@ 2025-03-11 1:27 Chenyuan Yang
2025-03-18 1:33 ` Andrew Jeffery
0 siblings, 1 reply; 2+ messages in thread
From: Chenyuan Yang @ 2025-03-11 1:27 UTC (permalink / raw)
To: gregkh, joel, andrew
Cc: linux-usb, linux-arm-kernel, linux-aspeed, linux-kernel, netdev,
Chenyuan Yang
The variable d->name, returned by devm_kasprintf(), could be NULL.
A pointer check is added to prevent potential NULL pointer dereference.
This is similar to the fix in commit 3027e7b15b02
("ice: Fix some null pointer dereference issues in ice_ptp.c").
This issue is found by our static analysis tool
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
---
drivers/usb/gadget/udc/aspeed-vhub/dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/gadget/udc/aspeed-vhub/dev.c b/drivers/usb/gadget/udc/aspeed-vhub/dev.c
index 573109ca5b79..a09f72772e6e 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/dev.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/dev.c
@@ -548,6 +548,9 @@ int ast_vhub_init_dev(struct ast_vhub *vhub, unsigned int idx)
d->vhub = vhub;
d->index = idx;
d->name = devm_kasprintf(parent, GFP_KERNEL, "port%d", idx+1);
+ if (!d->name)
+ return -ENOMEM;
+
d->regs = vhub->regs + 0x100 + 0x10 * idx;
ast_vhub_init_ep0(vhub, &d->ep0, d);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] usb: gadget: aspeed: Add NULL pointer check in ast_vhub_init_dev()
2025-03-11 1:27 [PATCH] usb: gadget: aspeed: Add NULL pointer check in ast_vhub_init_dev() Chenyuan Yang
@ 2025-03-18 1:33 ` Andrew Jeffery
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jeffery @ 2025-03-18 1:33 UTC (permalink / raw)
To: Chenyuan Yang, gregkh, joel
Cc: linux-usb, linux-arm-kernel, linux-aspeed, linux-kernel, netdev
On Mon, 2025-03-10 at 20:27 -0500, Chenyuan Yang wrote:
> The variable d->name, returned by devm_kasprintf(), could be NULL.
> A pointer check is added to prevent potential NULL pointer
> dereference.
> This is similar to the fix in commit 3027e7b15b02
> ("ice: Fix some null pointer dereference issues in ice_ptp.c").
>
> This issue is found by our static analysis tool
Which tool is this? Can it be run by others (me)?
>
> Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-18 1:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-11 1:27 [PATCH] usb: gadget: aspeed: Add NULL pointer check in ast_vhub_init_dev() Chenyuan Yang
2025-03-18 1:33 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®