[PATCH next] spi: spi-pci1xxxx: Fix error code in probe

[PATCH next] spi: spi-pci1xxxx: Fix error code in probe

[Dan Carpenter]

Return the error code if pci_alloc_irq_vectors() fails.  Don't return
success.

Fixes: b4608e944177 ("spi: spi-pci1xxxx: Fix Probe failure with Dual SPI instance with INTx interrupts")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/spi/spi-pci1xxxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-pci1xxxx.c b/drivers/spi/spi-pci1xxxx.c
index c6489e90b8b9..9112d8a1a0c8 100644
--- a/drivers/spi/spi-pci1xxxx.c
+++ b/drivers/spi/spi-pci1xxxx.c
@@ -765,7 +765,7 @@ static int pci1xxxx_spi_probe(struct pci_dev *pdev, const struct pci_device_id *
 							   PCI_IRQ_ALL_TYPES);
 			if (num_vector < 0) {
 				dev_err(&pdev->dev, "Error allocating MSI vectors\n");
-				return ret;
+				return num_vector;
 			}
 
 			init_completion(&spi_sub_ptr->spi_xfer_done);
-- 
2.47.2

Re: [PATCH next] spi: spi-pci1xxxx: Fix error code in probe

[Thangaraj.S]

On Fri, 2025-06-06 at 12:04 +0300, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Return the error code if pci_alloc_irq_vectors() fails.  Don't return
> success.
> 
> Fixes: b4608e944177 ("spi: spi-pci1xxxx: Fix Probe failure with Dual
> SPI instance with INTx interrupts")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> 

Reviewed-by: Thangaraj Samynathan <thangaraj.s@microchip.com>

Re: [PATCH next] spi: spi-pci1xxxx: Fix error code in probe

[Mark Brown]

On Fri, 06 Jun 2025 12:04:14 +0300, Dan Carpenter wrote:
> Return the error code if pci_alloc_irq_vectors() fails.  Don't return
> success.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-pci1xxxx: Fix error code in probe
      commit: 2b74aea6d078ade810a3b0f7d1bcfcba2eaad416

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark