* [PATCH -next] drm/hisilicon/hibmc: Fix COMPILE_TEST building without MMU
@ 2022-08-23 2:09 YueHaibing
2022-08-23 2:30 ` Randy Dunlap
2022-09-14 6:44 ` YueHaibing
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2022-08-23 2:09 UTC (permalink / raw)
To: xinliang.liu, tiantao6, jstultz, kong.kongxinwei, puck.chen,
airlied, daniel, tzimmermann, javierm
Cc: dri-devel, linux-kernel, YueHaibing
WARNING: unmet direct dependencies detected for DRM_TTM
Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && MMU [=n]
Selected by [y]:
- DRM_TTM_HELPER [=y] && HAS_IOMEM [=y] && DRM [=y]
- DRM_HISI_HIBMC [=y] && HAS_IOMEM [=y] && DRM [=y] && PCI [=y] && (ARM64 || COMPILE_TEST [=y])
Add missing MMU dependency to fix this.
Fixes: a0f25a6bb319 ("drm/hisilicon/hibmc: Allow to be built if COMPILE_TEST is enabled")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
index 073adfe438dd..e5ef1b573732 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig
+++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_HISI_HIBMC
tristate "DRM Support for Hisilicon Hibmc"
- depends on DRM && PCI && (ARM64 || COMPILE_TEST)
+ depends on DRM && PCI && (ARM64 || COMPILE_TEST) && MMU
select DRM_KMS_HELPER
select DRM_VRAM_HELPER
select DRM_TTM
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/hisilicon/hibmc: Fix COMPILE_TEST building without MMU
2022-08-23 2:09 [PATCH -next] drm/hisilicon/hibmc: Fix COMPILE_TEST building without MMU YueHaibing
@ 2022-08-23 2:30 ` Randy Dunlap
2022-09-14 6:44 ` YueHaibing
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-08-23 2:30 UTC (permalink / raw)
To: YueHaibing, xinliang.liu, tiantao6, jstultz, kong.kongxinwei,
puck.chen, airlied, daniel, tzimmermann, javierm
Cc: dri-devel, linux-kernel
On 8/22/22 19:09, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for DRM_TTM
> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && MMU [=n]
> Selected by [y]:
> - DRM_TTM_HELPER [=y] && HAS_IOMEM [=y] && DRM [=y]
> - DRM_HISI_HIBMC [=y] && HAS_IOMEM [=y] && DRM [=y] && PCI [=y] && (ARM64 || COMPILE_TEST [=y])
>
> Add missing MMU dependency to fix this.
>
> Fixes: a0f25a6bb319 ("drm/hisilicon/hibmc: Allow to be built if COMPILE_TEST is enabled")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> index 073adfe438dd..e5ef1b573732 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_HISI_HIBMC
> tristate "DRM Support for Hisilicon Hibmc"
> - depends on DRM && PCI && (ARM64 || COMPILE_TEST)
> + depends on DRM && PCI && (ARM64 || COMPILE_TEST) && MMU
> select DRM_KMS_HELPER
> select DRM_VRAM_HELPER
> select DRM_TTM
Yes, or this one from April 8, 2022:
https://lore.kernel.org/lkml/20220409030504.16089-1-rdunlap@infradead.org/
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/hisilicon/hibmc: Fix COMPILE_TEST building without MMU
2022-08-23 2:09 [PATCH -next] drm/hisilicon/hibmc: Fix COMPILE_TEST building without MMU YueHaibing
2022-08-23 2:30 ` Randy Dunlap
@ 2022-09-14 6:44 ` YueHaibing
1 sibling, 0 replies; 3+ messages in thread
From: YueHaibing @ 2022-09-14 6:44 UTC (permalink / raw)
To: xinliang.liu, tiantao6, jstultz, kong.kongxinwei, puck.chen,
airlied, daniel, tzimmermann, javierm
Cc: dri-devel, linux-kernel
ping...
On 2022/8/23 10:09, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for DRM_TTM
> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && MMU [=n]
> Selected by [y]:
> - DRM_TTM_HELPER [=y] && HAS_IOMEM [=y] && DRM [=y]
> - DRM_HISI_HIBMC [=y] && HAS_IOMEM [=y] && DRM [=y] && PCI [=y] && (ARM64 || COMPILE_TEST [=y])
>
> Add missing MMU dependency to fix this.
>
> Fixes: a0f25a6bb319 ("drm/hisilicon/hibmc: Allow to be built if COMPILE_TEST is enabled")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> index 073adfe438dd..e5ef1b573732 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_HISI_HIBMC
> tristate "DRM Support for Hisilicon Hibmc"
> - depends on DRM && PCI && (ARM64 || COMPILE_TEST)
> + depends on DRM && PCI && (ARM64 || COMPILE_TEST) && MMU
> select DRM_KMS_HELPER
> select DRM_VRAM_HELPER
> select DRM_TTM
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-14 6:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 2:09 [PATCH -next] drm/hisilicon/hibmc: Fix COMPILE_TEST building without MMU YueHaibing
2022-08-23 2:30 ` Randy Dunlap
2022-09-14 6:44 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®