* [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
@ 2017-05-18 16:57 Srinath Mannam
2017-05-19 6:25 ` Adrian Hunter
0 siblings, 1 reply; 6+ messages in thread
From: Srinath Mannam @ 2017-05-18 16:57 UTC (permalink / raw)
To: adrian.hunter
Cc: ulf.hansson, rjui, sbranden, jonmason, bcm-kernel-feedback-list,
linux-mmc, linux-arm-kernel, linux-kernel, Srinath Mannam
The stingray SDHCI hardware supports ACMD12 and automatically
issues after multi block transfer completed.
If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
on multi block read command with below error message:
Got data interrupt 0x00000002 even though no data
operation was in progress.
This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
ACM12 support in SDHCI hardware and suppress spurious interrupt.
Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 3275d49..61666d2 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -187,7 +187,8 @@ static const struct sdhci_iproc_data iproc_cygnus_data = {
};
static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = {
- .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK,
+ .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
+ SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
.quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN,
.ops = &sdhci_iproc_ops,
};
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
2017-05-18 16:57 [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read Srinath Mannam
@ 2017-05-19 6:25 ` Adrian Hunter
2017-05-22 11:52 ` Srinath Mannam
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Hunter @ 2017-05-19 6:25 UTC (permalink / raw)
To: Srinath Mannam
Cc: ulf.hansson, rjui, sbranden, jonmason, bcm-kernel-feedback-list,
linux-mmc, linux-arm-kernel, linux-kernel
On 18/05/17 19:57, Srinath Mannam wrote:
> The stingray SDHCI hardware supports ACMD12 and automatically
> issues after multi block transfer completed.
>
> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
> on multi block read command with below error message:
>
> Got data interrupt 0x00000002 even though no data
> operation was in progress.
>
> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 3275d49..61666d2 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -187,7 +187,8 @@ static const struct sdhci_iproc_data iproc_cygnus_data = {
> };
>
> static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = {
> - .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK,
> + .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK |
> + SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
> .quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN,
> .ops = &sdhci_iproc_ops,
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
2017-05-19 6:25 ` Adrian Hunter
@ 2017-05-22 11:52 ` Srinath Mannam
2017-05-22 12:01 ` Ulf Hansson
0 siblings, 1 reply; 6+ messages in thread
From: Srinath Mannam @ 2017-05-22 11:52 UTC (permalink / raw)
To: Adrian Hunter
Cc: Ulf Hansson, Ray Jui, Scott Branden, Jon Mason,
BCM Kernel Feedback, linux-mmc, linux-arm-kernel, linux-kernel
On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 18/05/17 19:57, Srinath Mannam wrote:
>> The stingray SDHCI hardware supports ACMD12 and automatically
>> issues after multi block transfer completed.
>>
>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>> on multi block read command with below error message:
>>
>> Got data interrupt 0x00000002 even though no data
>> operation was in progress.
>>
>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>
>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks Adrian...
Will it be possible to take this for Linux-4.12??
Regards,
Srinath
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
2017-05-22 11:52 ` Srinath Mannam
@ 2017-05-22 12:01 ` Ulf Hansson
2017-05-22 13:33 ` Srinath Mannam
0 siblings, 1 reply; 6+ messages in thread
From: Ulf Hansson @ 2017-05-22 12:01 UTC (permalink / raw)
To: Srinath Mannam
Cc: Adrian Hunter, Ray Jui, Scott Branden, Jon Mason,
BCM Kernel Feedback, linux-mmc, linux-arm-kernel, linux-kernel
On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> On 18/05/17 19:57, Srinath Mannam wrote:
>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>> issues after multi block transfer completed.
>>>
>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>> on multi block read command with below error message:
>>>
>>> Got data interrupt 0x00000002 even though no data
>>> operation was in progress.
>>>
>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>
>>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>
>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Thanks Adrian...
>
> Will it be possible to take this for Linux-4.12??
It's queued for 4.13, however are you saying it's a regression for
4.12? Then what commit fixes it?
Perhaps you even want this to go stable?
Kind regards
Uffe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
2017-05-22 12:01 ` Ulf Hansson
@ 2017-05-22 13:33 ` Srinath Mannam
2017-05-22 16:20 ` Ulf Hansson
0 siblings, 1 reply; 6+ messages in thread
From: Srinath Mannam @ 2017-05-22 13:33 UTC (permalink / raw)
To: Ulf Hansson
Cc: Adrian Hunter, Ray Jui, Scott Branden, Jon Mason,
BCM Kernel Feedback, linux-mmc, linux-arm-kernel, linux-kernel
On Mon, May 22, 2017 at 5:31 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
>> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>> On 18/05/17 19:57, Srinath Mannam wrote:
>>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>>> issues after multi block transfer completed.
>>>>
>>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>>> on multi block read command with below error message:
>>>>
>>>> Got data interrupt 0x00000002 even though no data
>>>> operation was in progress.
>>>>
>>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>>
>>>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>>
>>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>>
>> Thanks Adrian...
>>
>> Will it be possible to take this for Linux-4.12??
>
> It's queued for 4.13, however are you saying it's a regression for
> 4.12? Then what commit fixes it?
>
> Perhaps you even want this to go stable?
>
> Kind regards
> Uffe
Yes, this is regression for 4.12.
Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
Yes we want this to go in stable.
Thank you.
Regards,
Srinath.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read
2017-05-22 13:33 ` Srinath Mannam
@ 2017-05-22 16:20 ` Ulf Hansson
0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2017-05-22 16:20 UTC (permalink / raw)
To: Srinath Mannam
Cc: Adrian Hunter, Ray Jui, Scott Branden, Jon Mason,
BCM Kernel Feedback, linux-mmc, linux-arm-kernel, linux-kernel
On 22 May 2017 at 15:33, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
> On Mon, May 22, 2017 at 5:31 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>> On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@broadcom.com> wrote:
>>> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>>> On 18/05/17 19:57, Srinath Mannam wrote:
>>>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>>>> issues after multi block transfer completed.
>>>>>
>>>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>>>> on multi block read command with below error message:
>>>>>
>>>>> Got data interrupt 0x00000002 even though no data
>>>>> operation was in progress.
>>>>>
>>>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>>>
>>>>> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
>>>>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>>>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>>>
>>>> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>>>
>>> Thanks Adrian...
>>>
>>> Will it be possible to take this for Linux-4.12??
>>
>> It's queued for 4.13, however are you saying it's a regression for
>> 4.12? Then what commit fixes it?
>>
>> Perhaps you even want this to go stable?
>>
>> Kind regards
>> Uffe
>
> Yes, this is regression for 4.12.
> Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
> Yes we want this to go in stable.
>
Alright, applied for fixes and added a stable tag.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-22 16:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 16:57 [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read Srinath Mannam
2017-05-19 6:25 ` Adrian Hunter
2017-05-22 11:52 ` Srinath Mannam
2017-05-22 12:01 ` Ulf Hansson
2017-05-22 13:33 ` Srinath Mannam
2017-05-22 16:20 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®