From: Dave Hansen <dave.hansen@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
Aaron Lu <aaron.lu@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Kai Huang <kai.huang@intel.com>
Cc: "Molina Sabido, Gerardo" <gerardo.molina.sabido@intel.com>,
Zhimin Luo <zhimin.luo@intel.com>,
linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH v2 2/2] x86/sgx: Log information when a node lacks an EPC section
Date: Thu, 5 Sep 2024 12:02:09 -0700 [thread overview]
Message-ID: <585f9b58-3506-499e-ab9f-6076f2e83ef5@intel.com> (raw)
In-Reply-To: <D3YF42L6VP2I.12ZOBQPIPQ2BA@kernel.org>
On 9/5/24 07:24, Jarkko Sakkinen wrote:
>> + for_each_online_node(nid) {
>> + if (!node_isset(nid, sgx_numa_mask) &&
>> + node_state(nid, N_MEMORY) && node_state(nid, N_CPU))
>> + pr_info("node%d has both CPUs and memory but doesn't have an EPC section\n",
>> + nid);
> Is this enough, or is there anything that would need to be done
> automatically if this happens? With a tracepoint you could react to such
> even but I'm totally fine with this.
There's always the theoretical chance that there are nodes being
hotplugged or that this is all running in a VM that has some whacky
topology.
But this simple pr_info() provides good coverage for the common cases
and shouldn't be too much of a burden for the weridos.
next prev parent reply other threads:[~2024-09-05 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 8:08 [PATCH v2 0/2] SGX NUMA fix Aaron Lu
2024-09-05 8:08 ` [PATCH v2 1/2] x86/sgx: Fix deadlock in SGX NUMA node search Aaron Lu
2024-09-05 14:21 ` Jarkko Sakkinen
2024-09-05 8:08 ` [PATCH v2 2/2] x86/sgx: Log information when a node lacks an EPC section Aaron Lu
2024-09-05 14:24 ` Jarkko Sakkinen
2024-09-05 19:02 ` Dave Hansen [this message]
2024-09-05 22:16 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585f9b58-3506-499e-ab9f-6076f2e83ef5@intel.com \
--to=dave.hansen@intel.com \
--cc=aaron.lu@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=gerardo.molina.sabido@intel.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=x86@kernel.org \
--cc=zhimin.luo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®