mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Huang, Kai" <kai.huang@intel.com>
To: Aaron Lu <aaron.lu@intel.com>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	"Dave Hansen" <dave.hansen@linux.intel.com>
Cc: "Molina Sabido, Gerardo" <gerardo.molina.sabido@intel.com>,
	Zhimin Luo <zhimin.luo@intel.com>, <linux-sgx@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <x86@kernel.org>
Subject: Re: [PATCH v2 2/2] x86/sgx: Log information when a node lacks an EPC section
Date: Fri, 6 Sep 2024 10:16:13 +1200	[thread overview]
Message-ID: <a64525db-7339-48dd-922f-79348183b5d9@intel.com> (raw)
In-Reply-To: <20240905080855.1699814-3-aaron.lu@intel.com>



On 5/09/2024 8:08 pm, Aaron Lu wrote:
> For optimized performance, firmware typically distributes EPC sections
> evenly across different NUMA nodes. However, there are scenarios where
> a node may have both CPUs and memory but no EPC section configured. For
> example, in an 8-socket system with a Sub-Numa-Cluster=2 setup, there
> are a total of 16 nodes. Given that the maximum number of supported EPC
> sections is 8, it is simply not feasible to assign one EPC section to
> each node. This configuration is not incorrect - SGX will still operate
> correctly; it is just not optimized from a NUMA standpoint.
> 
> For this reason, log a message when a node with both CPUs and memory
> lacks an EPC section. This will provide users with a hint as to why they
> might be experiencing less-than-ideal performance when running SGX
> enclaves.
> 
> Suggested-by: Dave Hansen <dave.hansen@intel.com>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>

Acked-by: Kai Huang <kai.huang@intel.com>

      parent reply	other threads:[~2024-09-05 22:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05  8:08 [PATCH v2 0/2] SGX NUMA fix Aaron Lu
2024-09-05  8:08 ` [PATCH v2 1/2] x86/sgx: Fix deadlock in SGX NUMA node search Aaron Lu
2024-09-05 14:21   ` Jarkko Sakkinen
2024-09-05  8:08 ` [PATCH v2 2/2] x86/sgx: Log information when a node lacks an EPC section Aaron Lu
2024-09-05 14:24   ` Jarkko Sakkinen
2024-09-05 19:02     ` Dave Hansen
2024-09-05 22:16   ` Huang, Kai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a64525db-7339-48dd-922f-79348183b5d9@intel.com \
    --to=kai.huang@intel.com \
    --cc=aaron.lu@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=gerardo.molina.sabido@intel.com \
    --cc=jarkko@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sgx@vger.kernel.org \
    --cc=x86@kernel.org \
    --cc=zhimin.luo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®