* Re: [PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary
2017-03-13 11:28 ` [PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary Hans de Goede
@ 2017-03-13 11:43 ` Andy Shevchenko
2017-03-13 23:23 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2017-03-13 11:43 UTC (permalink / raw)
To: Hans de Goede
Cc: MyungJoo Ham, Chanwoo Choi, Chen-Yu Tsai, linux-kernel, Andy Shevchenko
On Mon, Mar 13, 2017 at 1:28 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> With the new more strict ACPI gpio code the dsdt's IoRestriction
> flags are honored on gpiod_get, but in some dsdt's it is wrong,
> so explicitly call gpiod_direction_input on the id gpio if
> necessary.
>
> This fixes the following errors when the int3496 code is used
> together with the new more strict ACPI gpio code:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
One nit below.
> [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ
> [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ
> [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio
> [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22
> [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22
> ret = PTR_ERR(data->gpio_usb_id);
> dev_err(dev, "can't request USB ID GPIO: %d\n", ret);
> return ret;
> + } else if (gpiod_get_direction(data->gpio_usb_id) != GPIOF_DIR_IN) {
It's obvious useless use of else. It doesn't harm, it doesn't bring
any value either.
> + dev_warn(dev, FW_BUG "USB ID GPIO not in input mode, fixing\n");
> + gpiod_direction_input(data->gpio_usb_id);
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary
2017-03-13 11:28 ` [PATCH v3] extcon: int3496: Set the id pin to direction-input if necessary Hans de Goede
2017-03-13 11:43 ` Andy Shevchenko
@ 2017-03-13 23:23 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2017-03-13 23:23 UTC (permalink / raw)
To: Hans de Goede, MyungJoo Ham, Chen-Yu Tsai; +Cc: linux-kernel, Andy Shevchenko
Hi,
On 2017년 03월 13일 20:28, Hans de Goede wrote:
> With the new more strict ACPI gpio code the dsdt's IoRestriction
> flags are honored on gpiod_get, but in some dsdt's it is wrong,
> so explicitly call gpiod_direction_input on the id gpio if
> necessary.
>
> This fixes the following errors when the int3496 code is used
> together with the new more strict ACPI gpio code:
>
> [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ
> [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ
> [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio
> [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22
> [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22
>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Warn about firmware bug when the dsdt's IoRestriction does not allow input
> Changes in v3:
> -Use FW_BUG macro
> -Group check together with gpiodesc error check
> -Keep lines within 80 chars limit
> ---
> drivers/extcon/extcon-intel-int3496.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread