From: Steev Klimaszewski <steev@kali.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Shawn Guo <shawn.guo@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: c630: Fix pinctrl pins properties
Date: Mon, 30 Nov 2020 11:25:58 -0600 [thread overview]
Message-ID: <58cf6829-4121-db46-04f7-0dc6c59b2053@kali.org> (raw)
In-Reply-To: <20201130170028.319798-1-bjorn.andersson@linaro.org>
On 11/30/20 11:00 AM, Bjorn Andersson wrote:
> The "pins" property takes an array of pin _names_, not pin numbers. Fix
> this.
>
> Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index 399aef2a0951..bb314973eb0c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -432,7 +432,7 @@ &tlmm {
> gpio-reserved-ranges = <0 4>, <81 4>;
>
> i2c3_hid_active: i2c2-hid-active {
> - pins = <37>;
> + pins = "gpio37";
> function = "gpio";
>
> input-enable;
> @@ -441,7 +441,7 @@ i2c3_hid_active: i2c2-hid-active {
> };
>
> i2c5_hid_active: i2c5-hid-active {
> - pins = <125>;
> + pins = "gpio125";
> function = "gpio";
>
> input-enable;
> @@ -450,7 +450,7 @@ i2c5_hid_active: i2c5-hid-active {
> };
>
> i2c11_hid_active: i2c11-hid-active {
> - pins = <92>;
> + pins = "gpio92";
> function = "gpio";
>
> input-enable;
> @@ -459,7 +459,7 @@ i2c11_hid_active: i2c11-hid-active {
> };
>
> wcd_intr_default: wcd_intr_default {
> - pins = <54>;
> + pins = "gpio54";
> function = "gpio";
>
> input-enable;
Tested-by: Steev Klimaszewski <steev@kali.org>
prev parent reply other threads:[~2020-11-30 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 17:00 Bjorn Andersson
2020-11-30 17:25 ` Steev Klimaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cf6829-4121-db46-04f7-0dc6c59b2053@kali.org \
--to=steev@kali.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®