* [PATCH] xen/privcmd: remove unused variable pageidx
@ 2017-11-08 13:00 Colin King
2017-11-08 13:30 ` Juergen Gross
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-11-08 13:00 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, xen-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable pageidx is assigned a value but it is never read, hence it
is redundant and can be removed. Cleans up clang warning:
drivers/xen/privcmd.c:199:2: warning: Value stored to 'pageidx'
is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/xen/privcmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index feca75b07fdd..1c909183c42a 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -191,13 +191,10 @@ static int traverse_pages_block(unsigned nelem, size_t size,
void *state)
{
void *pagedata;
- unsigned pageidx;
int ret = 0;
BUG_ON(size > PAGE_SIZE);
- pageidx = PAGE_SIZE;
-
while (nelem) {
int nr = (PAGE_SIZE/size);
struct page *page;
--
2.14.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xen/privcmd: remove unused variable pageidx
2017-11-08 13:00 [PATCH] xen/privcmd: remove unused variable pageidx Colin King
@ 2017-11-08 13:30 ` Juergen Gross
2017-11-08 21:22 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2017-11-08 13:30 UTC (permalink / raw)
To: Colin King, Boris Ostrovsky, xen-devel; +Cc: kernel-janitors, linux-kernel
On 08/11/17 14:00, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable pageidx is assigned a value but it is never read, hence it
> is redundant and can be removed. Cleans up clang warning:
>
> drivers/xen/privcmd.c:199:2: warning: Value stored to 'pageidx'
> is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/privcmd: remove unused variable pageidx
2017-11-08 13:30 ` Juergen Gross
@ 2017-11-08 21:22 ` Boris Ostrovsky
0 siblings, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2017-11-08 21:22 UTC (permalink / raw)
To: Juergen Gross, Colin King, xen-devel; +Cc: kernel-janitors, linux-kernel
On 11/08/2017 08:30 AM, Juergen Gross wrote:
> On 08/11/17 14:00, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Variable pageidx is assigned a value but it is never read, hence it
>> is redundant and can be removed. Cleans up clang warning:
>>
>> drivers/xen/privcmd.c:199:2: warning: Value stored to 'pageidx'
>> is never read
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied to for-linus-4.15.
-boris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-08 21:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08 13:00 [PATCH] xen/privcmd: remove unused variable pageidx Colin King
2017-11-08 13:30 ` Juergen Gross
2017-11-08 21:22 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®