* [PATCH] mailbox: return error in mbox_request_channel_byname
@ 2018-03-01 10:16 Fabien Dessenne
2018-03-01 13:51 ` Fabien DESSENNE
0 siblings, 1 reply; 2+ messages in thread
From: Fabien Dessenne @ 2018-03-01 10:16 UTC (permalink / raw)
To: Jassi Brar, linux-kernel
Cc: Benjamin Gaignard, Loic Pallardy, Arnaud Pouliquen, Ludovic Barre
If 'name' is not found in the "mbox-names" list, return an error
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
---
drivers/mailbox/mailbox.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
index 674b35f..a31970a 100644
--- a/drivers/mailbox/mailbox.c
+++ b/drivers/mailbox/mailbox.c
@@ -391,11 +391,12 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl,
of_property_for_each_string(np, "mbox-names", prop, mbox_name) {
if (!strncmp(name, mbox_name, strlen(name)))
- break;
+ return mbox_request_channel(cl, index);
index++;
}
- return mbox_request_channel(cl, index);
+ dev_err(cl->dev, "%s() mbox %s not found\n", __func__, name);
+ return ERR_PTR(-EINVAL);
}
EXPORT_SYMBOL_GPL(mbox_request_channel_byname);
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: mailbox: return error in mbox_request_channel_byname
2018-03-01 10:16 [PATCH] mailbox: return error in mbox_request_channel_byname Fabien Dessenne
@ 2018-03-01 13:51 ` Fabien DESSENNE
0 siblings, 0 replies; 2+ messages in thread
From: Fabien DESSENNE @ 2018-03-01 13:51 UTC (permalink / raw)
To: Jassi Brar, linux-kernel
Cc: Benjamin Gaignard, Loic PALLARDY, Arnaud POULIQUEN, Ludovic BARRE
oops! you can forget this patch, the original implementation is correct
BR
Fabien
On 01/03/18 11:16, Fabien DESSENNE wrote:
> If 'name' is not found in the "mbox-names" list, return an error
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
> drivers/mailbox/mailbox.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
> index 674b35f..a31970a 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -391,11 +391,12 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl,
>
> of_property_for_each_string(np, "mbox-names", prop, mbox_name) {
> if (!strncmp(name, mbox_name, strlen(name)))
> - break;
> + return mbox_request_channel(cl, index);
> index++;
> }
>
> - return mbox_request_channel(cl, index);
> + dev_err(cl->dev, "%s() mbox %s not found\n", __func__, name);
> + return ERR_PTR(-EINVAL);
> }
> EXPORT_SYMBOL_GPL(mbox_request_channel_byname);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-01 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01 10:16 [PATCH] mailbox: return error in mbox_request_channel_byname Fabien Dessenne
2018-03-01 13:51 ` Fabien DESSENNE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®