From: Jeff Layton <jlayton@kernel.org>
To: Wu Bo <wubo40@huawei.com>, sage@redhat.com, idryomov@gmail.com
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
liuzhiqiang26@huawei.com, linfeilong@huawei.com
Subject: Re: [PATCH] fs/ceph:fix speical error code in ceph_try_get_caps()
Date: Wed, 29 Apr 2020 11:37:25 -0400 [thread overview]
Message-ID: <591b050483a0326bbcaf075254a69bfefc77550f.camel@kernel.org> (raw)
In-Reply-To: <1588125715-188363-1-git-send-email-wubo40@huawei.com>
On Wed, 2020-04-29 at 10:01 +0800, Wu Bo wrote:
> There are 3 speical error codes: -EAGAIN/-EFBIG/-ESTALE.
> After call try_get_cap_refs function, judge the same
> error code -EAGAIN twice. So corrected the error code of judgment
> from -EAGAIN to -ESTAE.
>
> Signed-off-by: Wu Bo <wubo40@huawei.com>
> ---
> fs/ceph/caps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
> index 185db76..1a8e20e 100644
> --- a/fs/ceph/caps.c
> +++ b/fs/ceph/caps.c
> @@ -2749,7 +2749,7 @@ int ceph_try_get_caps(struct inode *inode, int need, int want,
>
> ret = try_get_cap_refs(inode, need, want, 0, flags, got);
> /* three special error codes */
> - if (ret == -EAGAIN || ret == -EFBIG || ret == -EAGAIN)
> + if (ret == -EAGAIN || ret == -EFBIG || ret == -ESTALE)
> ret = 0;
> return ret;
> }
Good catch! Merged into testing branch.
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2020-04-29 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 2:01 Wu Bo
2020-04-29 15:37 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591b050483a0326bbcaf075254a69bfefc77550f.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=sage@redhat.com \
--cc=wubo40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®