* [PATCH v1] extcon: int3496: Switch to devm_acpi_dev_add_driver_gpios() @ 2017-06-10 19:09 ` Andy Shevchenko 2017-06-12 1:01 ` Chanwoo Choi 0 siblings, 1 reply; 2+ messages in thread From: Andy Shevchenko @ 2017-06-10 19:09 UTC (permalink / raw) To: MyungJoo Ham, Chanwoo Choi, linux-kernel; +Cc: Andy Shevchenko Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify error path and fix potentially wrong assingment if ->probe() fails. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/extcon/extcon-intel-int3496.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c index 9d17984bbbd4..d9f9afe45961 100644 --- a/drivers/extcon/extcon-intel-int3496.c +++ b/drivers/extcon/extcon-intel-int3496.c @@ -94,8 +94,7 @@ static int int3496_probe(struct platform_device *pdev) struct int3496_data *data; int ret; - ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev), - acpi_int3496_default_gpios); + ret = devm_acpi_dev_add_driver_gpios(dev, acpi_int3496_default_gpios); if (ret) { dev_err(dev, "can't add GPIO ACPI mapping\n"); return ret; @@ -169,8 +168,6 @@ static int int3496_remove(struct platform_device *pdev) devm_free_irq(&pdev->dev, data->usb_id_irq, data); cancel_delayed_work_sync(&data->work); - acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev)); - return 0; } -- 2.11.0 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] extcon: int3496: Switch to devm_acpi_dev_add_driver_gpios() 2017-06-10 19:09 ` [PATCH v1] extcon: int3496: Switch to devm_acpi_dev_add_driver_gpios() Andy Shevchenko @ 2017-06-12 1:01 ` Chanwoo Choi 0 siblings, 0 replies; 2+ messages in thread From: Chanwoo Choi @ 2017-06-12 1:01 UTC (permalink / raw) To: Andy Shevchenko, MyungJoo Ham, linux-kernel On 2017년 06월 11일 04:09, Andy Shevchenko wrote: > Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify > error path and fix potentially wrong assingment if ->probe() fails. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/extcon/extcon-intel-int3496.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index 9d17984bbbd4..d9f9afe45961 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -94,8 +94,7 @@ static int int3496_probe(struct platform_device *pdev) > struct int3496_data *data; > int ret; > > - ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev), > - acpi_int3496_default_gpios); > + ret = devm_acpi_dev_add_driver_gpios(dev, acpi_int3496_default_gpios); > if (ret) { > dev_err(dev, "can't add GPIO ACPI mapping\n"); > return ret; > @@ -169,8 +168,6 @@ static int int3496_remove(struct platform_device *pdev) > devm_free_irq(&pdev->dev, data->usb_id_irq, data); > cancel_delayed_work_sync(&data->work); > > - acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev)); > - > return 0; > } > > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-12 1:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170610190957epcas5p1310ebdee45e6e0d94ac0ae8aafb53239@epcas5p1.samsung.com>
2017-06-10 19:09 ` [PATCH v1] extcon: int3496: Switch to devm_acpi_dev_add_driver_gpios() Andy Shevchenko
2017-06-12 1:01 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®