* [PATCH -next] crypto: ccp - Make ccp_register_rsa_alg static
@ 2019-03-19 13:50 Yue Haibing
2019-03-19 18:39 ` Gary R Hook
2019-03-28 6:06 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-19 13:50 UTC (permalink / raw)
To: herbert, thomas.lendacky, gary.hook, davem
Cc: linux-kernel, linux-crypto, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/crypto/ccp/ccp-crypto-rsa.c:251:5:
warning: symbol 'ccp_register_rsa_alg' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/crypto/ccp/ccp-crypto-rsa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
index 05850df..0b8aab00 100644
--- a/drivers/crypto/ccp/ccp-crypto-rsa.c
+++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
@@ -248,7 +248,8 @@ static struct ccp_rsa_def rsa_algs[] = {
}
};
-int ccp_register_rsa_alg(struct list_head *head, const struct ccp_rsa_def *def)
+static int ccp_register_rsa_alg(struct list_head *head,
+ const struct ccp_rsa_def *def)
{
struct ccp_crypto_akcipher_alg *ccp_alg;
struct akcipher_alg *alg;
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] crypto: ccp - Make ccp_register_rsa_alg static
2019-03-19 13:50 [PATCH -next] crypto: ccp - Make ccp_register_rsa_alg static Yue Haibing
@ 2019-03-19 18:39 ` Gary R Hook
2019-03-28 6:06 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Gary R Hook @ 2019-03-19 18:39 UTC (permalink / raw)
To: Yue Haibing, herbert, Lendacky, Thomas, Hook, Gary, davem
Cc: linux-kernel, linux-crypto
On 3/19/19 8:50 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/crypto/ccp/ccp-crypto-rsa.c:251:5:
> warning: symbol 'ccp_register_rsa_alg' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Gary R Hook <gary.hook@amd.com.
> ---
> drivers/crypto/ccp/ccp-crypto-rsa.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
> index 05850df..0b8aab00 100644
> --- a/drivers/crypto/ccp/ccp-crypto-rsa.c
> +++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
> @@ -248,7 +248,8 @@ static struct ccp_rsa_def rsa_algs[] = {
> }
> };
>
> -int ccp_register_rsa_alg(struct list_head *head, const struct ccp_rsa_def *def)
> +static int ccp_register_rsa_alg(struct list_head *head,
> + const struct ccp_rsa_def *def)
> {
> struct ccp_crypto_akcipher_alg *ccp_alg;
> struct akcipher_alg *alg;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] crypto: ccp - Make ccp_register_rsa_alg static
2019-03-19 13:50 [PATCH -next] crypto: ccp - Make ccp_register_rsa_alg static Yue Haibing
2019-03-19 18:39 ` Gary R Hook
@ 2019-03-28 6:06 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-03-28 6:06 UTC (permalink / raw)
To: Yue Haibing; +Cc: thomas.lendacky, gary.hook, davem, linux-kernel, linux-crypto
On Tue, Mar 19, 2019 at 09:50:35PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/crypto/ccp/ccp-crypto-rsa.c:251:5:
> warning: symbol 'ccp_register_rsa_alg' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/crypto/ccp/ccp-crypto-rsa.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-28 6:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 13:50 [PATCH -next] crypto: ccp - Make ccp_register_rsa_alg static Yue Haibing
2019-03-19 18:39 ` Gary R Hook
2019-03-28 6:06 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®