* [PATCH v1] ACPI: PM: Adjust messages regarding postponed ACPI PM
@ 2026-01-13 13:38 Rafael J. Wysocki
2026-01-22 2:06 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2026-01-13 13:38 UTC (permalink / raw)
To: Linux ACPI; +Cc: LKML, Linux PM, Dmitry Torokhov
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The debug messages added by commit f7599be2bb76 ("ACPI: PM: postpone
bringing devices to D0 unless we need them") in acpi_subsys_resume_early()
and acpi_subsys_resume() are not quite accurate because what is postponed
is not just a transition to D0, but also an adjustment of the device's
wakeup setting (which may involve disabling a GPE among other things).
Moreover, these messages don't even mention ACPI.
Rephrase them and adjust the style to match other messages in device_pm.c.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/device_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/acpi/device_pm.c
+++ b/drivers/acpi/device_pm.c
@@ -1251,7 +1251,7 @@ static int acpi_subsys_resume_early(stru
return 0;
if (pm && !pm->resume_early) {
- dev_dbg(dev, "postponing D0 transition to normal resume stage\n");
+ dev_dbg(dev, "Postponing ACPI PM to normal resume stage\n");
return 0;
}
@@ -1273,7 +1273,7 @@ static int acpi_subsys_resume(struct dev
int ret = 0;
if (!dev_pm_skip_resume(dev) && pm && !pm->resume_early) {
- dev_dbg(dev, "executing postponed D0 transition\n");
+ dev_dbg(dev, "Applying postponed ACPI PM\n");
ret = acpi_dev_resume(dev);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ACPI: PM: Adjust messages regarding postponed ACPI PM
2026-01-13 13:38 [PATCH v1] ACPI: PM: Adjust messages regarding postponed ACPI PM Rafael J. Wysocki
@ 2026-01-22 2:06 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2026-01-22 2:06 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux ACPI, LKML, Linux PM
On Tue, Jan 13, 2026 at 02:38:41PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The debug messages added by commit f7599be2bb76 ("ACPI: PM: postpone
> bringing devices to D0 unless we need them") in acpi_subsys_resume_early()
> and acpi_subsys_resume() are not quite accurate because what is postponed
> is not just a transition to D0, but also an adjustment of the device's
> wakeup setting (which may involve disabling a GPE among other things).
> Moreover, these messages don't even mention ACPI.
>
> Rephrase them and adjust the style to match other messages in device_pm.c.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Makes sense to me.
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/acpi/device_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/acpi/device_pm.c
> +++ b/drivers/acpi/device_pm.c
> @@ -1251,7 +1251,7 @@ static int acpi_subsys_resume_early(stru
> return 0;
>
> if (pm && !pm->resume_early) {
> - dev_dbg(dev, "postponing D0 transition to normal resume stage\n");
> + dev_dbg(dev, "Postponing ACPI PM to normal resume stage\n");
> return 0;
> }
>
> @@ -1273,7 +1273,7 @@ static int acpi_subsys_resume(struct dev
> int ret = 0;
>
> if (!dev_pm_skip_resume(dev) && pm && !pm->resume_early) {
> - dev_dbg(dev, "executing postponed D0 transition\n");
> + dev_dbg(dev, "Applying postponed ACPI PM\n");
> ret = acpi_dev_resume(dev);
> }
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-22 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-13 13:38 [PATCH v1] ACPI: PM: Adjust messages regarding postponed ACPI PM Rafael J. Wysocki
2026-01-22 2:06 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®