mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Lu, Yinghai" <yinghai.lu@amd.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: "Greg KH" <gregkh@suse.de>, "Andi Kleen" <ak@suse.de>,
	"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: RE: [Patch] PCI: check szhi when sz is 0 for 64 bit pref mem
Date: Mon, 6 Nov 2006 14:15:23 -0800	[thread overview]
Message-ID: <5986589C150B2F49A46483AC44C7BCA490719C@ssvlexmb2.amd.com> (raw)

-----Original Message-----
From: Andrew Morton [mailto:akpm@osdl.org] 
>I don't really understand what this patch does.
>We have a PCI device with a 64-bit BAR and the size is also 64-bit and
is
>larger than 4G, yes?

Yes

>But the code appears to already be attempting to handle such devices. 
>Confused.

The old code will 
Try to calculate the sz from lo 32 bit addr reg, and sz is 0 if the 64
bit resource size if 4G above, so it will continue can skip that
register, and it will go on try to treat the hi 32bit addr reg as
another 32 bit resource addr reg.

YH






             reply	other threads:[~2006-11-06 22:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06 22:15 Lu, Yinghai [this message]
2006-11-07  0:04 ` Andrew Morton
2006-11-07  4:35   ` Yinghai Lu
  -- strict thread matches above, loose matches on Subject: below --
2006-11-08 19:15 Lu, Yinghai
2006-11-10  0:50 ` Greg KH
2006-11-04  5:27 Yinghai Lu
2006-11-06 22:04 ` Andrew Morton
2006-11-08 18:19   ` Eric W. Biederman
2006-11-08 19:10     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5986589C150B2F49A46483AC44C7BCA490719C@ssvlexmb2.amd.com \
    --to=yinghai.lu@amd.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®