mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	srinivas.kandagatla@oss.qualcomm.com
Subject: Re: [PATCH v1 3/3] ASoC: codecs: lpass-wsa-macro: Guard optional NPL clock rate programming
Date: Thu, 16 Apr 2026 17:25:16 +0530	[thread overview]
Message-ID: <598c5171-3083-4122-9901-10d1812d54f8@oss.qualcomm.com> (raw)
In-Reply-To: <07c73c75-5ce8-46f2-bcfb-bb6d7fe0afca@oss.qualcomm.com>



On 4/14/2026 2:17 PM, Konrad Dybcio wrote:
> On 4/13/26 2:18 PM, Ajay Kumar Nandam wrote:
>> The NPL clock is only present on some platforms.  When it is absent,
>> wsa->npl remains NULL, but the driver unconditionally programs its rate.
>>
>> Guard clk_set_rate() for the NPL clock so platforms without NPL do not
>> attempt to access it.
>>
>> No functional change on platforms that provide the NPL clock.
>>
>> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
>> ---
> 
> If you dig into the definition of the function..
> 
> --- drivers/clk/clk.c ---
> 
> int clk_set_rate(struct clk *clk, unsigned long rate)
> {
>          int ret;
> 
>          if (!clk)
>                  return 0;
> 
> So let's drop this patch

ACK, will drop in next series.

Thanks
Ajay Kumar Nandam

> 
> Konrad


      reply	other threads:[~2026-04-16 11:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 12:18 [PATCH v1 0/3] ASoC: qcom: lpass: Switch VA/WSA macros to PM clock framework Ajay Kumar Nandam
2026-04-13 12:18 ` [PATCH v1 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM Ajay Kumar Nandam
2026-04-14  8:46   ` Konrad Dybcio
2026-04-20  8:54     ` Ajay Kumar Nandam
2026-04-14 12:02   ` Mark Brown
2026-04-16 11:57     ` Ajay Kumar Nandam
2026-04-13 12:18 ` [PATCH v1 2/3] ASoC: codecs: lpass-va-macro: " Ajay Kumar Nandam
2026-04-14 12:04   ` Mark Brown
2026-04-16 11:58     ` Ajay Kumar Nandam
2026-04-13 12:18 ` [PATCH v1 3/3] ASoC: codecs: lpass-wsa-macro: Guard optional NPL clock rate programming Ajay Kumar Nandam
2026-04-14  8:47   ` Konrad Dybcio
2026-04-16 11:55     ` Ajay Kumar Nandam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=598c5171-3083-4122-9901-10d1812d54f8@oss.qualcomm.com \
    --to=ajay.nandam@oss.qualcomm.com \
    --cc=broonie@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=srini@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®