mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: use KERN_CONT in dump_pagetable()
Date: Thu, 24 Aug 2017 03:14:03 -0600	[thread overview]
Message-ID: <599EB4FB02000078001730B8@prv-mh.provo.novell.com> (raw)
In-Reply-To: <599EB4FB02000078001730B8@prv-mh.provo.novell.com>

The lack of newlines in preceding format strings is a clear indication
that these were meant to be continuations of one another, and indeed
output ends up quite a bit more compact (and readable) that way.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
 arch/x86/mm/fault.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

--- 4.13-rc6/arch/x86/mm/fault.c
+++ 4.13-rc6-x86-dumppgt-cont/arch/x86/mm/fault.c
@@ -415,9 +415,9 @@ static void dump_pagetable(unsigned long
 		goto out;
 
 	pte = pte_offset_kernel(pmd, address);
-	printk("*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));
+	printk(KERN_CONT "*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));
 out:
-	printk("\n");
+	printk(KERN_CONT "\n");
 }
 
 #else /* CONFIG_X86_64: */
@@ -574,7 +574,7 @@ static void dump_pagetable(unsigned long
 	if (bad_address(p4d))
 		goto bad;
 
-	printk("P4D %lx ", p4d_val(*p4d));
+	printk(KERN_CONT "P4D %lx ", p4d_val(*p4d));
 	if (!p4d_present(*p4d) || p4d_large(*p4d))
 		goto out;
 
@@ -582,7 +582,7 @@ static void dump_pagetable(unsigned long
 	if (bad_address(pud))
 		goto bad;
 
-	printk("PUD %lx ", pud_val(*pud));
+	printk(KERN_CONT "PUD %lx ", pud_val(*pud));
 	if (!pud_present(*pud) || pud_large(*pud))
 		goto out;
 
@@ -590,7 +590,7 @@ static void dump_pagetable(unsigned long
 	if (bad_address(pmd))
 		goto bad;
 
-	printk("PMD %lx ", pmd_val(*pmd));
+	printk(KERN_CONT "PMD %lx ", pmd_val(*pmd));
 	if (!pmd_present(*pmd) || pmd_large(*pmd))
 		goto out;
 
@@ -598,9 +598,9 @@ static void dump_pagetable(unsigned long
 	if (bad_address(pte))
 		goto bad;
 
-	printk("PTE %lx", pte_val(*pte));
+	printk(KERN_CONT "PTE %lx", pte_val(*pte));
 out:
-	printk("\n");
+	printk(KERN_CONT "\n");
 	return;
 bad:
 	printk("BAD\n");

       reply	other threads:[~2017-08-24  9:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  9:14 Jan Beulich [this message]
2017-08-25 22:09 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=599EB4FB02000078001730B8@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®