* [PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in dw_dp_video_need_vsc_sdp()
@ 2025-12-25 18:44 Alper Ak
2025-12-26 0:40 ` Andy Yan
0 siblings, 1 reply; 2+ messages in thread
From: Alper Ak @ 2025-12-25 18:44 UTC (permalink / raw)
To: andy.yan
Cc: Alper Ak, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Dmitry Baryshkov, dri-devel,
linux-kernel
Since dw_dp_video_need_vsc_sdp() returns bool, have it return false
instead of -EINVAL if state is NULL.
Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 82aaf74e1bc0..36382956bbe0 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
state = dw_dp_get_bridge_state(dp);
if (!state)
- return -EINVAL;
+ return false;
if (!link->vsc_sdp_supported)
return false;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re:[PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in dw_dp_video_need_vsc_sdp()
2025-12-25 18:44 [PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in dw_dp_video_need_vsc_sdp() Alper Ak
@ 2025-12-26 0:40 ` Andy Yan
0 siblings, 0 replies; 2+ messages in thread
From: Andy Yan @ 2025-12-26 0:40 UTC (permalink / raw)
To: Alper Ak
Cc: andy.yan, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Dmitry Baryshkov, dri-devel,
linux-kernel
Hi Alper,
At 2025-12-26 02:44:01, "Alper Ak" <alperyasinak1@gmail.com> wrote:
>Since dw_dp_video_need_vsc_sdp() returns bool, have it return false
>instead of -EINVAL if state is NULL.
>
>Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
>Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
Reviewed-by: Andy Yan <andyshrk@163.com>
>---
> drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>index 82aaf74e1bc0..36382956bbe0 100644
>--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
>
> state = dw_dp_get_bridge_state(dp);
> if (!state)
>- return -EINVAL;
>+ return false;
>
> if (!link->vsc_sdp_supported)
> return false;
>--
>2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-26 0:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-25 18:44 [PATCH] drm/bridge: synopsys: dw-dp: fix signedness bug in dw_dp_video_need_vsc_sdp() Alper Ak
2025-12-26 0:40 ` Andy Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®